-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQS-379 | unit tests for processOrderBookActiveOrders #499
Conversation
Implements tests for processOrderBookActiveOrders orderbook usecase method. As a side effect introduces some helper methods and refactors some test cases.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Implements requested changes
Adds some docs.
Move OrderbookTestHelper and friends to orderbooktesting package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on test coverage and keeping the test readable!
* SQS-346 | handler tests, swagger API Implements unit tests for the orderbook active orders handler and adds swagger API for the endpoint
Quality Gate passedIssues Measures |
* SQS-377 | Unit test ProcessPool Introduces unit tests for Orderbook usecase ProcessPool method. * SQS-378 | WIP * SQS-377 | Unit test ProcessPool Adds requested improvements * SQS-377 | Unit test ProcessPool Add cosmwasmpool import * SQS-378 | Test GetActiveOrders Formatting * SQS-378 | Test GetActiveOrders Adds several more test cases * SQS-378 | Test GetActiveOrders Implements tests for GetActiveOrders orderbook usecase method * SQS-378 | Test GetActiveOrders * SQS-378 | Test GetActiveOrders Implements requested changes * SQS-378 | Test GetActiveOrders Cleanup * SQS-379 | unit tests for processOrderBookActiveOrders (#499) * SQS-379 | processOrderBookActiveOrders Implements tests for processOrderBookActiveOrders orderbook usecase method. As a side effect introduces some helper methods and refactors some test cases.
Implements tests for processOrderBookActiveOrders orderbook usecase method. As a side effect introduces some helper methods and refactors some test cases.