chore: active orders observability TODOs

ingest/usecase/ingest_usecase.go

@@ -303,6 +303,9 @@ func (p *ingestUseCase) parsePoolData(ctx context.Context, poolData []*types.Poo
 				// and to avoid potential deadlock.
 				go func() {
 					if err := p.orderBookUseCase.ProcessPool(ctx, poolResult.pool); err != nil {
+						// TODO: (alert) if failed to process orderbook pool, add an alert
+						// Prometheus metric counter and alert
+
 						p.logger.Error("failed to process orderbook pool", zap.Error(err), zap.Uint64("pool_id", poolID))
 					}
 				}()

orderbook/usecase/orderbook_usecase.go

@@ -131,7 +131,11 @@ func (o *orderbookUseCaseImpl) GetActiveOrders(ctx context.Context, address stri
 	for _, orderbook := range orderbooks {
 		orders, count, err := o.orderBookClient.GetActiveOrders(context.TODO(), orderbook.ContractAddress, address)
 		if err != nil {
-			o.logger.Info("failed to fetch active orders", zap.Any("contract", orderbook.ContractAddress), zap.Any("contract", address), zap.Any("err", err))
+			o.logger.Error("failed to fetch active orders", zap.Any("contract", orderbook.ContractAddress), zap.Any("contract", address), zap.Any("err", err))
+
+			// TODO: (alert) if failed to fetch active orders, add an alert
+			// Prometheus metric counter and alert
+
 			continue
 		}
 
@@ -159,7 +163,7 @@ func (o *orderbookUseCaseImpl) GetActiveOrders(ctx context.Context, address stri
 			if !ok {
 				o.logger.Info("tick not found", zap.Any("contract", orderbook.ContractAddress), zap.Any("ticks", order.TickId), zap.Any("ok", ok))
 
-				// TODO: if tick not found, add an alert
+				// TODO: (alert) if tick not found, add an alert
 				// Prometheus metric counter and alert
 			}
 
@@ -178,7 +182,11 @@ func (o *orderbookUseCaseImpl) GetActiveOrders(ctx context.Context, address stri
 				orderbook.ContractAddress,
 			)
 			if err != nil {
-				o.logger.Info("failed to create limit order", zap.Any("order", order), zap.Any("err", err))
+				o.logger.Error("failed to create limit order", zap.Any("order", order), zap.Any("err", err))
+
+				// TODO: (alert) if failed to create limit order, add an alert
+				// Prometheus metric counter and alert
+
 				continue
 			}
 
@@ -221,7 +229,10 @@ func (o *orderbookUseCaseImpl) createLimitOrder(
 	percentClaimed := placedQuantityDec.Sub(quantityDec).Quo(placedQuantityDec)
 
 	// Calculate normalization factor for price
-	normalizationFactor := osmomath.NewDec(10).Power(uint64(quoteAsset.Decimals - baseAsset.Decimals))
+	normalizationFactor, err := o.tokensUsecease.GetSpotPriceScalingFactorByDenom(baseAsset.Symbol, quoteAsset.Symbol)
+	if err != nil {
+		return orderbookdomain.LimitOrder{}, fmt.Errorf("error getting spot price scaling factor: %w", err)
+	}
 
 	// Determine tick values and unrealized cancels based on order direction
 	var tickEtas, tickUnrealizedCancelled int64
@@ -288,7 +299,7 @@ func (o *orderbookUseCaseImpl) createLimitOrder(
 	}
 
 	// Calculate normalized price
-	normalizedPrice := price.Dec().Quo(normalizationFactor)
+	normalizedPrice := price.Dec().Mul(normalizationFactor)
 
 	// Convert placed_at to a nano second timestamp
 	placedAt, err := strconv.ParseInt(order.PlacedAt, 10, 64)