Reintroduce flight records #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* POC: Flight recording of slow requests (above 500ms) * go mods * config & fixes * lint
| @@ -1,13 +1,13 @@ | |||
| # syntax=docker/dockerfile:1 | |||
|
|
|||
| ARG GO_VERSION="1.21" | |||
There was a problem hiding this comment.
Proposed change: bump version from go1.21 to go1.22
| @@ -1,8 +1,8 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| # See README.md#Debugging for more information | |||
|
|
|||
| ARG GO_VERSION="1.21" | |||
| ARG RUNNER_IMAGE="golang:1.21" | |||
There was a problem hiding this comment.
Proposed change: bump version from go1.21 to go1.22
p0mvn
approved these changes
May 29, 2024
p0mvn
reviewed
May 30, 2024
|
Committed a small nit to changelog. Thank you again @deividaspetraitis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix for docker image build process that was failing previously ( please see #254 ).
Failure was caused by a wrong Go version since
runtime/trace: flight recordingpackage was introduced ingo1.22as an experental feature and was not yet available atgo1.21version, please see https://go-review.googlesource.com/c/exp/+/550257Proposed change is to bump version from
go1.21togo1.22in Docker images.Also this PR reintroduces flight records.