Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nhooyr.io/websocket dependency #8803

Closed
wants to merge 3 commits into from
Closed

fix nhooyr.io/websocket dependency #8803

wants to merge 3 commits into from

Conversation

robert-zaremba
Copy link
Contributor

Closes: #XXX

What is the purpose of the change

When cleaning a go cache and trying to compile the project, we can observe the following errors:

go: nhooyr.io/[email protected]: reading nhooyr.io/websocket/go.mod at revision v1.8.7: unknown revision v1.8.7
ante/sendblock.go:6:2: nhooyr.io/[email protected]: reading nhooyr.io/websocket/go.mod at revision v1.8.7: unknown revision v1.8.7
ante/sendblock.go:11:2: nhooyr.io/[email protected]: reading nhooyr.io/websocket/go.mod at revision v1.8.7: unknown revision v1.8.7
...

This is because the resource moved permanently:

curl nhooyr.io/websocket
<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx</center>
</body>
</html>

Testing and Verifying

make build

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2024 •
edited
Loading

Walkthrough

The CHANGELOG.md file has been updated to include new entries under the "Unreleased" section, categorizing changes into "State Breaking," "Config," "State Compatible," and "State Machine Breaking." The update documents various dependency version bumps, fixes for governance module state export issues, concurrency issues in tests, and enhancements in the x/gauges module. The entries are formatted to include tags and references to GitHub issues, following the specified guidelines.

Changes

File Change Summary
CHANGELOG.md Updated with new entries for "Unreleased" section, detailing dependency bumps, fixes, and enhancements.

Possibly related PRs

Suggested labels

A:no-changelog, V:state/compatible/backport

Suggested reviewers

  • czarcas7ic
  • PaddyMc
  • nicolaslara
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ec51fc7 and 3c430fd.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🔇 Additional comments (3)
CHANGELOG.md (3)

70-70: LGTM: Well formatted changelog entry

The changelog entry appropriately documents the websocket dependency fix under the correct section with proper PR reference.

Line range hint 73-111: LGTM: Well structured version section

The v19.2.0 section is well organized with:

  • Clear categorization of changes
  • Proper PR references
  • Concise descriptions
  • Appropriate categorization of changes based on their impact

Line range hint 1-5824: LGTM: Well maintained changelog

The changelog demonstrates good practices:

  • Consistent formatting and structure
  • Clear categorization of changes
  • Good traceability through PR references
  • Proper semantic versioning
  • Clear marking of breaking changes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

113-113: Improve changelog entry format and details.

The changelog entry for the websocket dependency fix should follow the standard format and include more details:

-* [#](https://github.com/osmosis-labs/osmosis/pull/) fix: nhooyr.io/websocket dependency (moved permanently)
+* [#8803](https://github.com/osmosis-labs/osmosis/pull/8803) fix: Update nhooyr.io/websocket dependency to handle 301 permanent redirect, fixing compilation errors during clean builds
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9e46748 and ec51fc7.

⛔ Files ignored due to path filters (1)
  • go.mod is excluded by !**/*.mod
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

mattverse
mattverse approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🙇

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added Stale and removed Stale labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Nov 24, 2024
@github-actions github-actions bot closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mattverse mattverse mattverse approved these changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert-zaremba @mattverse