Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in place testnet logs #8731

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: in place testnet logs #8731

merged 2 commits into from
Sep 27, 2024

Conversation

czarcas7ic
Copy link
Member

Closes: #XXX

What is the purpose of the change

Replaces the addrbook.json when running in place testnet. Results in logs that go from this:

Screenshot 2024-09-26 at 4 33 52 PM

To this:

Screenshot 2024-09-26 at 4 47 54 PM

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v26.x backport patches to v26.x branch labels Sep 26, 2024
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@czarcas7ic czarcas7ic marked this pull request as ready for review September 26, 2024 23:28
Copy link
Contributor

coderabbitai bot commented Sep 26, 2024

Walkthrough

The pull request updates the changelog to include a new entry for pull request #8731, which addresses issues with the handling of testnet logs. It highlights improvements in the logging mechanism during testnet operations while retaining previous entries that describe additional queries in x/gauges and a fix for managing multiple temporary directories during command executions. No changes were made to the declarations of exported or public entities.

Changes

File Change Summary
CHANGELOG.md Added an entry for PR #8731 regarding improvements to testnet log handling.

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between edaa948 and 24bb2fe.

⛔ Files ignored due to path filters (6)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • osmomath/go.mod is excluded by !**/*.mod
  • osmoutils/go.mod is excluded by !**/*.mod
  • x/epochs/go.mod is excluded by !**/*.mod
  • x/ibc-hooks/go.mod is excluded by !**/*.mod
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🔇 Additional comments (11)
CHANGELOG.md (11)

56-56: New feature: In-place testnet logs fix

This change improves the logging output during testnet operation. It's a good improvement for developers and node operators working with testnets.


Line range hint 62-62: Config change: Disable SQS by default in app.toml

This change modifies the default configuration. Node operators should be aware of this change and adjust their configurations if they rely on SQS.


Line range hint 65-67: State compatible changes: Additional events and queries

These changes add new events and queries, which are beneficial for developers and integrators. They don't break state compatibility, which is good.


Line range hint 69-70: Refactoring: Make cosmwasmpool's create pool CLI generic

This change improves the flexibility of the CLI for creating pools. It's a good improvement for usability.


Line range hint 79-80: Logging improvement: Track incentive accumulator truncation

This change adds logging to track incentive accumulator truncation, which is helpful for debugging and monitoring the system's behavior.


Line range hint 84-84: New feature: In-place testnet creation CLI

This addition improves the developer experience by providing an easier way to create testnets. It's a valuable tool for testing and development.


Line range hint 85-86: Performance improvement: Optimize epoch processing

These optimizations in epoch processing and TWAP pruning logic can lead to significant performance improvements, especially for nodes processing a large number of transactions.


Line range hint 90-91: Performance improvement: Comet mempool optimizations

These improvements to the Comet mempool are likely to enhance the overall performance of the system, particularly in handling transactions. This is a valuable update for node operators.


Line range hint 68-68: API break: Changing PoolI.SpotPrice API

This is an important API change that could affect integrations. Developers using this API need to be notified and update their code accordingly.

#!/bin/bash
# Check for usage of SpotPrice in the codebase
spot_price_usage=$(rg "SpotPrice" --type go)
echo "Usage of SpotPrice in the codebase:"
echo "$spot_price_usage"

Line range hint 71-73: Important change: Switch to sdkmath types

This change could have wide-ranging effects throughout the codebase. It's important to verify that all mathematical operations are still correct after this change.

#!/bin/bash
# Check for usage of new sdkmath types in the codebase
sdkmath_usage=$(rg "sdkmath" --type go)
echo "Usage of sdkmath in the codebase:"
echo "$sdkmath_usage"

58-58: State breaking change: Bump cosmwasm-optimizer

Upgrading the cosmwasm-optimizer could potentially affect contract deployments and executions. This change needs careful consideration during the upgrade process.

Warning

Review ran into problems

🔥 Problems

Error running LanguageTool: LanguageTool error: Unknown error


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PaddyMc PaddyMc merged commit 6cb0bd5 into main Sep 27, 2024
1 check passed
@PaddyMc PaddyMc deleted the adam/in-place-testnet-logs branch September 27, 2024 08:17
mergify bot pushed a commit that referenced this pull request Sep 27, 2024
* in place testnet logs

* add changelog

(cherry picked from commit 6cb0bd5)
PaddyMc pushed a commit that referenced this pull request Sep 27, 2024
* in place testnet logs

* add changelog

(cherry picked from commit 6cb0bd5)

Co-authored-by: Adam Tucker <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Nov 7, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v26.x backport patches to v26.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants