Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cosmos.msg.v1.service to message services #8689

Closed
wants to merge 15 commits into from
Closed

fix: add cosmos.msg.v1.service to message services #8689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9960409
Update expected_keepers.go
faddat Sep 10, 2024
d30f999
Revert "Update expected_keepers.go"
faddat Sep 10, 2024
fd4fa2e
add annotation: option (cosmos.msg.v1.service) = true;
faddat Sep 10, 2024
ec0255b
Generated protofile changes
invalid-email-address Sep 10, 2024
c4042b5
go mod tidy
faddat Sep 10, 2024
2edb786
Merge branch 'faddat/give-the-proto-annotation' of https://github.com…
faddat Sep 10, 2024
323b159
Update CHANGELOG.md
faddat Sep 10, 2024
f607ea9
revert changes to the gamm proto file and their result
faddat Sep 10, 2024
5783e36
Generated protofile changes
invalid-email-address Sep 10, 2024
bf053ef
Merge remote-tracking branch 'origin/main' into faddat/give-the-proto…
faddat Sep 12, 2024
5424b14
Update tx.proto
faddat Sep 12, 2024
9919ef5
got it :)
faddat Sep 12, 2024
d6fc505
Merge branch 'faddat/give-the-proto-annotation' of https://github.com…
faddat Sep 12, 2024
a74379b
Generated protofile changes
invalid-email-address Sep 12, 2024
2c05f1e
Merge remote-tracking branch 'origin/main' into faddat/give-the-proto…
faddat Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* [#8663](https://github.com/osmosis-labs/osmosis/pull/8663) fix: protorev throws a nil pointer
* [#8676](https://github.com/osmosis-labs/osmosis/pull/8676) fix: update enforce sub-authenticator to be greater than 1 error message
* [#8682](https://github.com/osmosis-labs/osmosis/pull/8682) chore: bump cosmwasm-optimizer
* [#8869](https://github.com/osmosis-labs/osmosis/pull/8689) add missing service annotation to tx proto files service section

### Config

Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/concentratedliquidity/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import "cosmos/base/v1beta1/coin.proto";
option go_package = "github.com/osmosis-labs/osmosis/v26/x/concentrated-liquidity/types";

service Msg {
option (cosmos.msg.v1.service) = true;

rpc CreatePosition(MsgCreatePosition) returns (MsgCreatePositionResponse);
rpc WithdrawPosition(MsgWithdrawPosition)
returns (MsgWithdrawPositionResponse);
Expand Down
4 changes: 3 additions & 1 deletion proto/osmosis/cosmwasmpool/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
syntax = "proto3";
package osmosis.cosmwasmpool.v1beta1;

import "cosmos/msg/v1/msg.proto";
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the missing import file.

The import statement import "cosmos/msg/v1/msg.proto"; is added to support the new option in the Msg service. However, the static analysis tool reports that the imported file does not exist, which could lead to compilation errors.

Please ensure that the cosmos/msg/v1/msg.proto file is available in the expected location or update the import path to point to the correct location of the file.

Do you want me to help resolve this issue? I can try to locate the missing file in the repository or suggest alternative import paths.

Tools
buf

4-4: import "cosmos/msg/v1/msg.proto": file does not exist

(COMPILE)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think things are okay here Mr. Rabbit. Will wait for the team's review though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faddat Understood! I'll be here if you need any further assistance after the team's review. 😊


option go_package = "github.com/osmosis-labs/osmosis/v26/x/cosmwasmpool/types";

service Msg {}
service Msg { option (cosmos.msg.v1.service) = true; }
2 changes: 2 additions & 0 deletions proto/osmosis/ibchooks/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v26/x/ibc-hooks/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;

// EmitIBCAck checks the sender can emit the ack and writes the IBC
// acknowledgement
rpc EmitIBCAck(MsgEmitIBCAck) returns (MsgEmitIBCAckResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/incentives/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v26/x/incentives/types";

service Msg {
option (cosmos.msg.v1.service) = true;

rpc CreateGauge(MsgCreateGauge) returns (MsgCreateGaugeResponse);
rpc AddToGauge(MsgAddToGauge) returns (MsgAddToGaugeResponse);
rpc CreateGroup(MsgCreateGroup) returns (MsgCreateGroupResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/lockup/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v26/x/lockup/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;

// LockTokens lock tokens
rpc LockTokens(MsgLockTokens) returns (MsgLockTokensResponse);
// BeginUnlockingAll begin unlocking all tokens
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/poolmanager/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v26/x/poolmanager/types";

service Msg {
option (cosmos.msg.v1.service) = true;

rpc SwapExactAmountIn(MsgSwapExactAmountIn)
returns (MsgSwapExactAmountInResponse);
rpc SwapExactAmountOut(MsgSwapExactAmountOut)
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/protorev/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v26/x/protorev/types";

service Msg {
option (cosmos.msg.v1.service) = true;

// SetHotRoutes sets the hot routes that will be explored when creating
// cyclic arbitrage routes. Can only be called by the admin account.
rpc SetHotRoutes(MsgSetHotRoutes) returns (MsgSetHotRoutesResponse) {
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/smartaccount/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v26/x/smart-account/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;

rpc AddAuthenticator(MsgAddAuthenticator)
returns (MsgAddAuthenticatorResponse);
rpc RemoveAuthenticator(MsgRemoveAuthenticator)
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/superfluid/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v26/x/superfluid/types";

// Msg defines the Msg service.
service Msg {
option (cosmos.msg.v1.service) = true;

// Execute superfluid delegation for a lockup
rpc SuperfluidDelegate(MsgSuperfluidDelegate)
returns (MsgSuperfluidDelegateResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/tokenfactory/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v26/x/tokenfactory/types";

// Msg defines the tokefactory module's gRPC message service.
service Msg {
option (cosmos.msg.v1.service) = true;

rpc CreateDenom(MsgCreateDenom) returns (MsgCreateDenomResponse);
rpc Mint(MsgMint) returns (MsgMintResponse);
rpc Burn(MsgBurn) returns (MsgBurnResponse);
Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/txfees/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import "cosmos/msg/v1/msg.proto";
option go_package = "github.com/osmosis-labs/osmosis/v26/x/txfees/types";

service Msg {
option (cosmos.msg.v1.service) = true;

rpc SetFeeTokens(MsgSetFeeTokens) returns (MsgSetFeeTokensResponse);
}

Expand Down
2 changes: 2 additions & 0 deletions proto/osmosis/valsetpref/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ option go_package = "github.com/osmosis-labs/osmosis/v26/x/valset-pref/types";

// Msg defines the valset-pref module's gRPC message service.
service Msg {
option (cosmos.msg.v1.service) = true;

// SetValidatorSetPreference creates a set of validator preference.
// This message will process both create + update request.
rpc SetValidatorSetPreference(MsgSetValidatorSetPreference)
Expand Down
158 changes: 79 additions & 79 deletions x/concentrated-liquidity/types/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading