Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update gogoproto to v1.4.11 and golang.org/x/exp to latest, sdk bump #8253

Merged
merged 8 commits into from
May 16, 2024
Merged

chore: update gogoproto to v1.4.11 and golang.org/x/exp to latest, sdk bump #8253

merged 8 commits into from
May 16, 2024

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 11, 2024

Closes: #XXX

What is the purpose of the change

I'm looking to try out new traces:
https://go.dev/blog/execution-traces-2024

That requires a newer version of exp package

We force replace it here due to an API break in gogoproto.

The new gogoproto tag already contains the fix. As a result, I propose bumping it.

Testing and Verifying

I will run a node with this change to ensure no state-breaks

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v24.x backport patches to v24.x branch A:backport/v25.x backport patches to v25.x branch labels May 11, 2024
@p0mvn p0mvn changed the title feat: update gogoproto to v1.4.11 feat: update gogoproto to v1.4.11 and golang.org/x/exp to latest May 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@p0mvn
Copy link
Member Author

p0mvn commented May 11, 2024

TODO: If we decide to merge this, cosmos SDK PR should be merged first and dependency retagged from branch

@p0mvn p0mvn changed the title feat: update gogoproto to v1.4.11 and golang.org/x/exp to latest chore: update gogoproto to v1.4.11 and golang.org/x/exp to latest, sdk bump May 11, 2024
This was referenced May 11, 2024
Closed
Closed
@p0mvn
Copy link
Member Author

p0mvn commented May 15, 2024

OK deps updated to point to SDK main. Tested this for a while on v24 against state breaks

@p0mvn p0mvn removed the A:backport/v24.x backport patches to v24.x branch label May 15, 2024
@p0mvn p0mvn marked this pull request as ready for review May 15, 2024 19:39
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 15, 2024 •
edited
Loading

Walkthrough

The recent updates optimize and modernize the codebase. Caching was introduced to the poolmanager.GetPoolModule function to enhance performance. Dependencies were updated, including gogoproto to version 1.4.11 and modules from golang.org/x/exp, ensuring the latest features and security improvements. Additionally, the deserialization time for GetDefaultTakerFee() was removed, likely to streamline operations and reduce overhead.

Changes

File Change Summary
CHANGELOG.md Documented caching, dependency updates, and deserialization time removal
.../poolmanager.go Added caching for GetPoolModule result
.../go.mod Updated gogoproto to v1.4.11 and golang.org/x/exp
.../fees.go Removed deserialization time for GetDefaultTakerFee()

In the code, a rabbit hops with glee,
Caching pools for swift decree.
Dependencies fresh, no bugs to see,
Deserialization time set free.
🎩✨
The code now dances, light and spry,
With every change, it reaches the sky.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 72cbde9 and 1c53ef0.
Files ignored due to path filters (10)
  • go.mod is excluded by !**/*.mod, !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • osmomath/go.mod is excluded by !**/*.mod, !**/*.mod
  • osmomath/go.sum is excluded by !**/*.sum, !**/*.sum
  • osmoutils/go.mod is excluded by !**/*.mod, !**/*.mod
  • osmoutils/go.sum is excluded by !**/*.sum, !**/*.sum
  • x/epochs/go.mod is excluded by !**/*.mod, !**/*.mod
  • x/epochs/go.sum is excluded by !**/*.sum, !**/*.sum
  • x/ibc-hooks/go.mod is excluded by !**/*.mod, !**/*.mod
  • x/ibc-hooks/go.sum is excluded by !**/*.sum, !**/*.sum
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (9)
CHANGELOG.md (9)

Line range hint 1026-1026: Correct heading level increment.

- #### State Breaking
+ ### State Breaking

Line range hint 1038-1038: Correct heading level increment.

- #### API
+ ### API

Line range hint 1047-1047: Correct heading level increment.

- #### Features
+ ### Features

Line range hint 1052-1052: Correct heading level increment.

- #### Bug Fixes
+ ### Bug Fixes

Line range hint 1104-1104: Correct heading level increment.

- #### API breaks
+ ### API breaks

Line range hint 365-365: Remove trailing punctuation in heading.

- ### Misc Improvements & Bug Fixes:
+ ### Misc Improvements & Bug Fixes

Line range hint 628-628: Format the bare URL properly.

- * Ref: https://keepachangelog.com/en/1.0.0/
+ * [Ref](https://keepachangelog.com/en/1.0.0/)

Line range hint 686-686: Format the bare URL properly.

- The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

Line range hint 1267-1267: Avoid empty links.

- * [#3014]
+ * [#3014](https://github.com/osmosis-labs/osmosis/issues/3014)

@p0mvn p0mvn merged commit 5cdab9f into main May 16, 2024
1 check passed
@p0mvn p0mvn deleted the roman/update-gogoproto branch May 16, 2024 14:12
mergify bot pushed a commit that referenced this pull request May 16, 2024
@p0mvn @mergify
chore: update gogoproto to v1.4.11 and golang.org/x/exp to latest, sd…
4046b12 
…k bump (#8253)

* feat: update gogoproto to v1.4.11

* changelog

* update golang.org/x/exp

* submodules

* more updates

* update

* update deps

(cherry picked from commit 5cdab9f)

# Conflicts:
#	go.mod
#	osmomath/go.mod
#	osmoutils/go.mod
#	x/epochs/go.mod
@mergify mergify bot mentioned this pull request May 16, 2024
Merged
6 tasks
p0mvn added a commit that referenced this pull request May 20, 2024
@p0mvn
chore: update gogoproto to v1.4.11 and golang.org/x/exp to latest, sd…
5c61ba5 
…k bump (backport #8253)
p0mvn added a commit that referenced this pull request May 20, 2024
@mergify @p0mvn
chore: update gogoproto to v1.4.11 and golang.org/x/exp to latest, sd…
c44a659 
…k bump (backport #8253) (#8273)

Co-authored-by: Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@PaddyMc PaddyMc PaddyMc approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

Assignees
No one assigned
Labels
A:backport/v25.x backport patches to v25.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @PaddyMc