Properly create the module account for auction

app/upgrades/v25/upgrades.go

@@ -4,6 +4,9 @@ import (
 	"errors"
 	"sort"
 
+	"github.com/osmosis-labs/osmosis/osmoutils"
+	auctiontypes "github.com/skip-mev/block-sdk/x/auction/types"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/types/module"
 	upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
@@ -67,6 +70,11 @@ func CreateUpgradeHandler(
 			return nil, errors.New("unsupported chain ID")
 		}
 
+		// Ensure the auction module account is properly created to avoid sniping
+		err = osmoutils.CreateModuleAccountByName(ctx, keepers.AccountKeeper, auctiontypes.ModuleName)
+		if err != nil {
+			return nil, err
+		}
 		// update block-sdk params
 		if err := keepers.AuctionKeeper.SetParams(ctx, AuctionParams); err != nil {
 			return nil, err

app/upgrades/v25/upgrades_test.go

@@ -1,6 +1,8 @@
 package v25_test
 
 import (
+	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
+	auctiontypes "github.com/skip-mev/block-sdk/x/auction/types"
 	"testing"
 	"time"
 
@@ -48,6 +50,12 @@ func (s *UpgradeTestSuite) TestUpgrade() {
 		s.App.BeginBlocker(s.Ctx, abci.RequestBeginBlock{})
 	})
 
+	// check auction module account
+	acc := s.App.AccountKeeper.GetModuleAccount(s.Ctx, auctiontypes.ModuleName)
+	s.Require().NotNil(acc)
+	s.Require().Equal(auctiontypes.ModuleName, acc.GetName())
+	s.Require().Equal(authtypes.NewModuleAddress(auctiontypes.ModuleName), acc.GetAddress())
+
 	// check auction params
 	params, err := s.App.AuctionKeeper.GetParams(s.Ctx)
 	s.Require().NoError(err)

osmoutils/module_account.go

@@ -84,3 +84,22 @@ func CreateModuleAccount(ctx sdk.Context, ak AccountKeeper, addr sdk.AccAddress)
 	ak.SetAccount(ctx, acc)
 	return nil
 }
+
+// CreateModuleAccountByName creates a module account at the provided name
+func CreateModuleAccountByName(ctx sdk.Context, ak AccountKeeper, name string) error {
+	addr := authtypes.NewModuleAddress(name)
+	err := CanCreateModuleAccountAtAddr(ctx, ak, addr)
+	if err != nil {
+		return err
+	}
+
+	acc := ak.NewAccount(
+		ctx,
+		authtypes.NewModuleAccount(
+			authtypes.NewBaseAccountWithAddress(addr),
+			name,
+		),
+	)
+	ak.SetAccount(ctx, acc)
+	return nil
+}