Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Verify transfer addresses in Observer (backport #7943) #7956

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: Verify transfer addresses in Observer (backport #7943) #7956

merged 1 commit into from
Apr 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 5, 2024

Epic: #7643

What is the purpose of the change

  • Add destination address verification for x/bridge observer

Testing and Verifying

  • Unit tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Summary by CodeRabbit

  • New Features

    • Enhanced Bitcoin observer functionality for improved error messaging and transaction relevance logic.
    • Introduced new features to Osmosis observer including mode settings and better error handling.

  • Bug Fixes

    • Fixed Bitcoin address validation in memo retrieval.
    • Improved test scenarios for both Bitcoin and Osmosis observers to cover various transaction types and scenarios.

  • Refactor

    • Streamlined Bitcoin and Osmosis observers' code for better maintainability and performance.
This is an automatic backport of pull request #7943 done by [Mergify](https://mergify.com).

@Kormick @mergify
feat: Verify transfer addresses in Observer (#7943)
c400427 
* feat: Verify transfer addresses

* chore: typo

(cherry picked from commit 1b3449b)
@mergify mergify bot assigned Kormick Apr 5, 2024
@czarcas7ic czarcas7ic merged commit 1d4a21e into v24.x Apr 5, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the mergify/bp/v24.x/pr-7943 branch April 5, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees

@Kormick Kormick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czarcas7ic @Kormick