-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fast nodes module whitelist config parse (backport #7737) #7738
Conversation
* fix config parse * changelog * tidy * duplicate changelog entry (cherry picked from commit a4f3ece) # Conflicts: # go.mod # go.sum # osmomath/go.mod # osmoutils/go.mod # x/epochs/go.mod # x/ibc-hooks/go.mod
Cherry-pick of a4f3ece has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Closes: #XXX
What is the purpose of the change
There is some really strange bug with appOpts.Get for string slices. I spent hours trying to figure out the root cause, but was unable to. Basically, it sets the result as an array of length 1, no mater how it is formated, along with adding an extra set of square brackets around the result.
So ["lockup"] becomes [lockup], ["lockup", "superfluid"] becomes [lockup superfluid], etc.
This just adds separate logic to get around this problem.
Testing and Verifying
Tested various settings:
No setting present
Setting is blank array
Single module
Multiple modules
All behaved as expected.
Summary by CodeRabbit
This is an automatic backport of pull request #7737 done by [Mergify](https://mergify.com).