Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fast nodes module whitelist config parse (backport #7737) #7738

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 14, 2024

Closes: #XXX

What is the purpose of the change

There is some really strange bug with appOpts.Get for string slices. I spent hours trying to figure out the root cause, but was unable to. Basically, it sets the result as an array of length 1, no mater how it is formated, along with adding an extra set of square brackets around the result.

So ["lockup"] becomes [lockup], ["lockup", "superfluid"] becomes [lockup superfluid], etc.

This just adds separate logic to get around this problem.

Testing and Verifying

Tested various settings:

No setting present
Setting is blank array
Single module
Multiple modules

All behaved as expected.

Summary by CodeRabbit

  • New Features
    • Improved node module processing speed by implementing a whitelist feature.
    • Updated version numbers and merged changes for enhanced P2P logic.

This is an automatic backport of pull request #7737 done by [Mergify](https://mergify.com).

* fix config parse

* changelog

* tidy

* duplicate changelog entry

(cherry picked from commit a4f3ece)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmoutils/go.mod
#	x/epochs/go.mod
#	x/ibc-hooks/go.mod
Copy link
Contributor Author

mergify bot commented Mar 14, 2024

Cherry-pick of a4f3ece has failed:

On branch mergify/bp/v23.x/pr-7737
Your branch is up to date with 'origin/v23.x'.

You are currently cherry-picking commit a4f3ecea.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md
	modified:   cmd/osmosisd/cmd/root.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   go.sum
	both modified:   osmomath/go.mod
	both modified:   osmoutils/go.mod
	both modified:   x/epochs/go.mod
	both modified:   x/ibc-hooks/go.mod

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

coderabbitai bot commented Mar 14, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@czarcas7ic czarcas7ic merged commit 35a14d5 into v23.x Mar 14, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the mergify/bp/v23.x/pr-7737 branch March 14, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant