fix: cw pool migration prop #7590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
p0mvn
commented
Feb 22, 2024
czarcas7ic
approved these changes
Feb 22, 2024
ValarDragon
approved these changes
Feb 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* fix: cw pool migration prop * changelog * Update x/cosmwasmpool/client/cli/tx.go (cherry picked from commit b619966) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* fix: cw pool migration prop * changelog * Update x/cosmwasmpool/client/cli/tx.go (cherry picked from commit b619966)
czarcas7ic
pushed a commit
that referenced
this pull request
Feb 22, 2024
* fix: cw pool migration prop (#7590) * fix: cw pool migration prop * changelog * Update x/cosmwasmpool/client/cli/tx.go (cherry picked from commit b619966) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Roman <[email protected]>
czarcas7ic
pushed a commit
that referenced
this pull request
Feb 22, 2024
* fix: cw pool migration prop * changelog * Update x/cosmwasmpool/client/cli/tx.go (cherry picked from commit b619966) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
The CLI logic did not allow providing only one of code ID and bytecode but the state-machine logic required only one to be set.
Testing and Verifying
https://testnet.mintscan.io/osmosis-testnet/proposals/176