chore: remove cl test modules #7254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
V:state/compatible/backport
p0mvn
approved these changes
Jan 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
* remove cl test modules * remove from go work (cherry picked from commit 2946424) # Conflicts: # tests/cl-go-client/README.md # tests/cl-go-client/go.mod # tests/cl-go-client/go.sum # tests/cl-go-client/main.go
p0mvn
pushed a commit
that referenced
this pull request
Jan 8, 2024
* chore: remove cl test modules (#7254) * remove cl test modules * remove from go work (cherry picked from commit 2946424) # Conflicts: # tests/cl-go-client/README.md # tests/cl-go-client/go.mod # tests/cl-go-client/go.sum # tests/cl-go-client/main.go * fix merge conflict --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Whenever having to do go mod updates, there is overhead in also syncing the cl test modules as well. AFAIK these are not being used, and if they are I think its better off outside of the primary repo.