fix: config overwrite fails with exit code 1 if wrong permissions #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
ValarDragon
approved these changes
Jan 5, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
) * fix: config overwrite fails with exit code 1 if wrong permissions * changelog * lint (cherry picked from commit 74ea7f1)
p0mvn
added a commit
that referenced
this pull request
Jan 5, 2024
) (#7247) * fix: config overwrite fails with exit code 1 if wrong permissions * changelog * lint (cherry picked from commit 74ea7f1) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This PR fixes bug where osmosisd fails with non-zero code if fails to overwrite the file due to permissions:
https://github.com/cometbft/cometbft/blob/fe45483be36ebfea7e172a3ad949e8fe09a8fd95/libs/os/os.go#L83
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)