feat: add amino signing support to tokenfactory messages #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
madrezaz
requested review from
mattverse,
nicolaslara and
p0mvn
as code owners
mattverse
approved these changes
Dec 18, 2023
Comment on lines
+54
to
+56
| RegisterLegacyAminoCodec(authzcodec.Amino) | ||
| RegisterLegacyAminoCodec(govcodec.Amino) | ||
| RegisterLegacyAminoCodec(groupcodec.Amino) |
There was a problem hiding this comment.
annoying that we need to do this :(
There was a problem hiding this comment.
yeah, I hope we can remove these in newer versions with textual sign mode
|
Considering you tagged the PR as state breaking, should I move the changelog entry to another section? |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Should be fine :) thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR changes the codec being used for getting sign bytes of tokenfactory module messages, in order to allow amino signing.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)