Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forgotten redelegation codec #6758

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Add forgotten redelegation codec #6758

merged 3 commits into from
Oct 27, 2023

Conversation

ValarDragon
Copy link
Member

Add a codec we forgot to add.

Please close / just redo the PR if I did this wrong

@ValarDragon ValarDragon added the V:state/breaking State machine breaking PR label Oct 25, 2023
@mattverse
Copy link
Member

mattverse commented Oct 25, 2023

I'm wondering how hard it would be to change codebase so that we can get these automatically registered, maybe somewhere in module.go

@ValarDragon ValarDragon merged commit 0d36c62 into main Oct 27, 2023
1 check passed
@ValarDragon ValarDragon deleted the dev/add_redelegate_codec branch October 27, 2023 15:52
@ValarDragon
Copy link
Member Author

yeah it really shouldnt be that hard. We can probs do some reflection hack as well.

I think later SDK versions should have this automated though? Lets ask in SDK slack?

@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants