Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/max tick test #6661

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Test/max tick test #6661

merged 2 commits into from
Oct 12, 2023

Conversation

hoangdv2429
Copy link
Contributor

@hoangdv2429 hoangdv2429 commented Oct 10, 2023

Closes: #6333

What is the purpose of the change

add test case for MaxTick as described in the issue

Testing and Verifying

This change added tests and can be verified as follows:

  • Added unit test that validates maxTick case in TestTickToSqrtPrice

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@hoangdv2429 hoangdv2429 added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Oct 10, 2023
@mattverse mattverse merged commit eec71f8 into main Oct 12, 2023
@mattverse mattverse deleted the test/maxTick_test branch October 12, 2023 07:44
pysel pushed a commit that referenced this pull request Oct 17, 2023
* fix typo

* add case for maxTick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog C:x/concentrated-liquidity V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(CL): TestTickToSqrtPrice for MaxTick test case
3 participants