refactor: breaking CL tick to sqrt price math min spot price relaxation #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please only merge after #6317 is merged |
p0mvn
force-pushed
the
roman/tick-to-sqrt-breaking
branch
from
ed299b2 to
7db80ff
Compare
AlpinYukseloglu
approved these changes
Sep 5, 2023
6 tasks
p0mvn
force-pushed
the
roman/tick-to-sqrt-breaking
branch
from
8e7774c to
cc7ab11
Compare
github-actions
bot
added
C:x/lockup
C:CLI
C:app-wiring
p0mvn
force-pushed
the
roman/tick-to-sqrt-breaking
branch
from
cc7ab11 to
7db80ff
Compare
github-actions
bot
removed
C:x/lockup
C:CLI
C:app-wiring
|
I added a test skip here post-approval: 74f96ef It was in one of the future PRs anyway and I'm tracking removing that check. Noticed that CI is being flaky from the last merge, and this should fix it. |
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6046
What is the purpose of the change
This PR is a follow-up to: #6317
It relaxes the tick-to-sqrt-price conversion to support the extended minimum range.
Testing and Verifying
The extended price range has been thoroughly tested in previous PRs related to #5726 while guarding state compatibility with the simple check that is removed here.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)