-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v44 auth upgrade bug #618
Conversation
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 18.44% 18.44% -0.01%
==========================================
Files 172 172
Lines 24233 24235 +2
==========================================
Hits 4470 4470
- Misses 18998 19000 +2
Partials 765 765
Continue to review full report at Codecov.
|
This look as a dirty hack. I'm thinking about changing the map value type to a structure with priority. |
Let's continue the discussion in the SDK issue |
Yeah, but can't wait 2+ weeks for it to land tho |
Seeing as this is being tested on vega upgrade as well, merging |
sure, was only saying that it's feels hacky, but solves the problem. In 0.44 we don't have other solution which is not breaking :/ except the patch for x/auth. So your one is the best so far. I have created a draft PR for 0.45 to change the structure. |
ah 100% agreed, its absolutely a gross workaround lol. Thanks for getting a better fix into 0.45 |
Workaround for cosmos/cosmos-sdk#10591 , https://github.com/provenance-io/provenance/blob/407c89a7d73854515894161e1526f9623a94c368/app/upgrades.go#L86-L122
Just do auth upgrade last.
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer