fix: cl spotprice query #5863
Merged
fix: cl spotprice query #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doggystylez
requested review from
czarcas7ic,
p0mvn and
mattverse
as code owners
|
upon futher investigation, this affects and reverse the twap for cl pools also, making this state breaking |
Closed
mattverse
reviewed
Jul 24, 2023
| @@ -91,7 +91,7 @@ func GetCmdPool() (*osmocli.QueryDescriptor, *queryproto.PoolRequest) { | |||
|
|
|||
| func GetCmdSpotPrice() (*osmocli.QueryDescriptor, *queryproto.SpotPriceRequest) { | |||
| return &osmocli.QueryDescriptor{ | |||
| Use: "spot-price <pool-ID> [quote-asset-denom] [base-asset-denom]", | |||
| Use: "spot-price <pool-ID> [base-asset-denom] [quote-asset-denom]", | |||
There was a problem hiding this comment.
note to other reviewers: This changed due to order of proto query client
AlpinYukseloglu
approved these changes
Jul 31, 2023
czarcas7ic
approved these changes
Aug 2, 2023
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
fixed inconsistency in spot price query for cl pools - the base and quote denoms are being reversed due to the spot price querier providing them in reverse order:
osmosis/x/poolmanager/client/query_proto_wrap.go
Line 151 in c26756d
and edited spot price cli command help text to reflect actual behavior of "denom in, denom out"
note - I also noticed that the path for this query doesn't include the v1beta1 version name
osmosis/proto/osmosis/poolmanager/v1beta1/query.proto
Lines 70 to 72 in c26756d
Testing and Verifying
This change modified the spotprice test to swap the args and can be verified as follows:
<lcd>/osmosis/poolmanager/pools/1066/prices?base_asset_denom=uosmo"e_asset_denom=ibc/0CD3A0285E1341859B5E86B6AB7682F023D03E97607CCC1DC95706411D866DF7Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)