Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/docs: CL swap tool #5456

Merged
merged 5 commits into from
Jun 7, 2023
Merged

feat/docs: CL swap tool #5456

merged 5 commits into from
Jun 7, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 7, 2023

Closes: #XXX

What is the purpose of the change

Swap tool for data team.

Updated docs on how to use it. Please read the edited README in this file for context.

Additionally, added docs on how to use this on testnet.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Jun 7, 2023
@github-actions github-actions bot added C:docs Improvements or additions to documentation T:build labels Jun 7, 2023
@p0mvn p0mvn marked this pull request as ready for review June 7, 2023 16:45
@p0mvn p0mvn requested a review from a team as a code owner June 7, 2023 16:45
@p0mvn p0mvn requested review from czarcas7ic and removed request for a team June 7, 2023 16:45
@p0mvn p0mvn force-pushed the roman/cl-swap-tool branch from bc5311c to 2dade3e Compare June 7, 2023 18:12
AlpinYukseloglu
AlpinYukseloglu approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding!

@p0mvn p0mvn merged commit 0c97a97 into main Jun 7, 2023
@p0mvn p0mvn deleted the roman/cl-swap-tool branch June 7, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic

Assignees
No one assigned
Labels
A:no-changelog C:docs Improvements or additions to documentation T:build V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @AlpinYukseloglu