Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: query pool accumulator rewards (APR #2 and 3) #5367

Merged
merged 2 commits into from
May 31, 2023
Merged

feat: query pool accumulator rewards (APR #2 and 3) #5367

merged 2 commits into from
May 31, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 31, 2023 •
edited
Loading

Closes: #XXX

What is the purpose of the change

This PR introduces changes necessary for the data team to compute the position APRs.

Data team needs to track 4 things to be able to do that:

  1. Spread reward and uptime accumulator tick updates in events (refactor: emit tick spread factor reward and uptime reward events when tick is crossed (APR calc #1) #5366)
  2. Query pool spread rewards accumulator (this PR)
  3. Query pool uptime accumulator (this PR)
  4. Query reward accumulators for each individual tick (future PR)

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels May 31, 2023
@p0mvn p0mvn marked this pull request as ready for review May 31, 2023 02:19
@p0mvn p0mvn requested a review from czarcas7ic as a code owner May 31, 2023 02:19
@p0mvn p0mvn mentioned this pull request May 31, 2023
Merged
6 tasks
mattverse
mattverse approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogoproto tag needs to be changed, other then that lgtm

proto/osmosis/concentrated-liquidity/query.proto Outdated Show resolved Hide resolved
mattverse
mattverse approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogoproto tag needs to be changed, other then that lgtm

@p0mvn p0mvn merged commit dfdac4a into main May 31, 2023
@p0mvn p0mvn deleted the roman/query-pool-rewards branch May 31, 2023 17:26
pysel pushed a commit that referenced this pull request Jun 6, 2023
@p0mvn @pysel
feat: query pool accumulator rewards (APR #2 and 3) (#5367)
dcb25b0 
* feat: query pool accumulator rewards (APR #2 and 3)

* proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
A:no-changelog C:CLI C:x/concentrated-liquidity V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @mattverse