Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a section of PR template #5166

Merged
merged 2 commits into from
May 12, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,6 @@ Closes: #XXX

*(E.g.: This pull request improves documation of area A by adding ....*
p0mvn marked this conversation as resolved.
Show resolved Hide resolved


## Brief Changelog

*(for example:)*

- *The metadata is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *Daemons retrieve the RPC data from the blob cache*


## Testing and Verifying

*(Please pick one of the following options)*
Expand All @@ -45,6 +35,11 @@ This change added tests and can be verified as follows:

## Documentation and Release Note

- Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
- Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? (yes / no)
- How is the feature or change documented? (not applicable / specification (`x/<module>/spec/`) / [Osmosis docs repo](https://github.com/osmosis-labs/docs) / not documented)
- [ ] Does this pull request introduce a new feature or user-facing behavior changes?
- [ ] Changelog entry added to `Unreleased` section of `CHANGELOG.md`?

Where is the change documented?
- [ ] Specification (`x/{module}/README.md`)
- [ ] Osmosis documentation site
- [ ] Code comments?
- [ ] N/A