Code

lint all tests#5127

Code

Closed

faddat wants to merge 158 commits intomainosmosis-labs/osmosis:mainfrom lint-all-testsosmosis-labs/osmosis:lint-all-testsCopy head branch name to clipboard

+787-1,553

Commits

Commits on Apr 27, 2023

• TestJoinSwapExactAmountInConsistency

  DongLieu

  committed
  70cfbdc

Commits on May 4, 2023

• add cases corners

  DongLieu

  committed
  37074cc

Commits on May 7, 2023

• run golangci-lint and resolve ineffectual assignment to err

  faddat

  committed
  f5dc71d

• go work sync

  faddat

  committed
  9fa7369

• waypoint in "check all errors in tests"

  faddat

  committed
  c688011

• 50 error checks remaining

  faddat

  committed
  ac5bcd2

• 42 errors remaining to check in tests

  faddat

  committed
  3105a8a

• all tests pass and as many errors as possible have been checked

  faddat

  committed
  cbed0c4

• revert enabling golangci-lint to check tests, as it would always fail afterwards

  faddat

  committed
  31327a6

• update changelog

  faddat

  committed
  2acfd0e

• use thelper in golangci-lint without linting every test

  faddat

  committed
  1e9eb0c

• Update tests/e2e/containers/containers.go

  Show description for d624769
  

  faddat

  and

  p0mvn

  committed
  d624769

• Merge remote-tracking branch 'origin/main' into faddat/check-all-errors

  faddat

  committed
  e9c621f

• thelper for incentives bench test

  faddat

  committed
  d616f90

• unused code in tests

  faddat

  committed
  0a59632

• Update x/concentrated-liquidity/position_test.go

  Show description for 8ae270d
  

  faddat

  and

  czarcas7ic

  authored
  8ae270d

• Merge branch 'main' into faddat/check-all-errors

  faddat

  authored
  ddc5487

• fix forced type assertions

  faddat

  committed
  560388c

• revert change to linter config

  faddat

  committed
  b70f80a

Commits on May 8, 2023

• Update tests/e2e/e2e_test.go

  Show description for b2d1fab
  

  faddat

  and

  pysel

  authored
  b2d1fab

• Update x/concentrated-liquidity/pool_test.go

  Show description for 85c7ecb
  

  faddat

  and

  pysel

  authored
  85c7ecb

• skip pool = poolI

  faddat

  committed
  8e573d7

• update swap_test.go to test that cl type assertions fail

  faddat

  committed
  eb9cc68

• trial

  faddat

  committed
  56c6152

• we needed pool because it's used to CalcInGivenOut

  faddat

  committed
  daa610e

• Merge branch 'main' into faddat/check-all-errors

  faddat

  authored
  93f5581

• Merge remote-tracking branch 'origin/main' into faddat/check-all-errors

  faddat

  committed
  e243555

• re-add skip state sync

  faddat

  committed
  16c6c97

• Merge branch 'faddat/unused-in-tests' into accumulate

  faddat

  committed
  39f6fc4

• Merge branch 'faddat/forcetypeassert' into accumulate

  faddat

  committed
  6bc25aa

• everything but oddities

  faddat

  committed
  268d276

Commits on May 9, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  a558e7b

• Update CHANGELOG.md

  Show description for ce1675f
  

  faddat

  and

  p0mvn

  authored
  ce1675f

• Merge branch 'main' into faddat/check-all-errors

  faddat

  authored
  66c0616

• more test cases for TestValidatePoolLiquidity()

  DongLieu

  committed
  e7d37d0

• return error in SetIncentiveRecord

  faddat

  committed
  d05c314

• revert change to .golanci.yml

  faddat

  committed
  1d07817

• Update x/concentrated-liquidity/pool_test.go

  Show description for 9d2ee5a
  

  faddat

  and

  p0mvn

  authored
  9d2ee5a

• Update x/concentrated-liquidity/pool_test.go

  Show description for bc461ab
  

  faddat

  and

  p0mvn

  authored
  bc461ab

• Update x/gamm/keeper/swap_test.go

  Show description for cb22e58
  

  faddat

  and

  p0mvn

  authored
  cb22e58

• Merge branch 'faddat/check-all-errors' into lint-all-tests

  faddat

  committed
  b9f45b1

• Merge remote-tracking branch 'origin/faddat/forcetypeassert' into lint-all-tests

  faddat

  committed
  7ee03f6

• golangci-lint run ./... --fix

  faddat

  committed
  8ed22fc

• style: lint stableswap the same as the rest of osmosis (#5105)

  Show description for 2d93ccf
  faddat

  committed
  2d93ccf

Commits on May 10, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  20d9c04

• Add test cases for TestSwapOutAmtGivenIn()

  DongLieu

  committed
  500ea1f

• add return err for prepareCustomBalancerPool()

  DongLieu

  committed
  624cadb

• add testcase with non zero exit fee

  DongLieu

  committed
  f4d0555

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  56e64ff

• res.liquidity

  faddat

  committed
  b6b2da4

• mask generated code from the linter, and fix makezero lint

  faddat

  committed
  981eb4f

• almost :) - commit contains numerous small lint fixes for tests

  faddat

  committed
  665726f

• fix spelling mistake :)

  faddat

  committed
  5a5b16a

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  179f100

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  beb40e5

Commits on May 11, 2023

• rename

  DongLieu

  committed
  b51a248

• add calculations lead to number

  DongLieu

  committed
  365e8d2

• remove testcase poolExitFee > 0

  DongLieu

  committed
  26260cd

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  3f0c439

Commits on May 12, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  8f99b2d

• suite => s

  faddat

  committed
  faf7fce

• suite -> s

  faddat

  committed
  bc8434c

• don't needlessly use fmt.Sprintf

  faddat

  committed
  1bf171e

Commits on May 15, 2023

• Update x/concentrated-liquidity/incentives_test.go

  Show description for 4e130d6
  

  faddat

  and

  mattverse

  authored
  4e130d6

• Update x/twap/export_test.go

  Show description for 9fe5b67
  

  faddat

  and

  mattverse

  authored
  9fe5b67

• Update x/twap/export_test.go

  Show description for 931cce4
  

  faddat

  and

  mattverse

  authored
  931cce4

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  ef8811b

Commits on May 16, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  6a6e558

• sync

  faddat

  committed
  07442dc

• make all tests pass again

  faddat

  committed
  9732d6f

• remove swap_test.go from skipped files

  faddat

  committed
  32cdbf7

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  14a97a9

Commits on May 17, 2023

• standardize the type assertions

  faddat

  committed
  9fe383e

• lint cli_test.go

  faddat

  committed
  d4f65b6

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  79094f2

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  45cda39

• sync

  faddat

  committed
  8427685

• fix tests

  faddat

  committed
  58d260f

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  b32c43a

• Merge remote-tracking branch 'origin/main' into dong/issue3849

  faddat

  committed
  f5e7d33

• change linter settings

  faddat

  committed
  3273192

• Merge branch 'dong/issue3849' into lint-all-tests

  faddat

  committed
  86d210a

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  dc15a1a

• merge Dong's changes to x/gamm

  faddat

  committed
  1e3d4b7

• Revert "Merge branch 'dong/issue3849' into lint-all-tests"

  Show description for 23f4650
  faddat

  committed
  23f4650

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  01c7aca

• merge main, sync start gamm over again

  faddat

  committed
  80207d4

Commits on May 18, 2023

• bookmark

  faddat

  committed
  d4badba

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  f8f5136

Commits on May 19, 2023

• save linting progress

  faddat

  committed
  508b973

• s. to suite

  faddat

  committed
  4bb0346

• fully passing

  faddat

  committed
  e74f277

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  cd4ba9c

• misc cleanup lets make sure we did not break e2e

  faddat

  committed
  6c7694c

• deprecation notices

  faddat

  committed
  44a8475

• lint cliq bench test

  faddat

  committed
  cf79dbe

• cliq tests

  faddat

  committed
  65e186e

• nolint the final two type assertions on chatgpt's advice

  faddat

  committed
  e7c8248

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  c9caf07

• sync

  faddat

  committed
  964857d

• sync

  faddat

  committed
  1afd9a7

Commits on May 25, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  83c40d1

• adjust run time for golangci and autofixes after merging main and accepting "theirs"

  faddat

  committed
  d949a20

Commits on May 30, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  906a746

• sync

  faddat

  committed
  1cd43c7

Commits on Jun 14, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  5296021

• sync

  faddat

  committed
  94726e3

Commits on Jun 28, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  509991f

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  118930a

• t.Helper() and b.Helper() + run golangci-lint ./... --fix

  faddat

  committed
  77a7004

• remove unused function

  faddat

  committed
  4e58f86

• remove unused functions, types, and fields in structs

  faddat

  committed
  4e99ba6

• eliminate naked returns

  faddat

  committed
  3cc8284

• eliminate naked returns

  faddat

  committed
  8241efe

• suite -> s

  faddat

  committed
  4233d0f

• ineffectual assignments

  faddat

  committed
  ad0213f

• misspelling and double imports

  faddat

  committed
  fa88191

• cleanup (check errors and suite -> s)

  faddat

  committed
  908378e

Commits on Jun 30, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  2838c57

Commits on Jul 5, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  5eb6ce2

• lint

  faddat

  committed
  03c0630

• merge succeded, this is cleanup of various lints

  faddat

  committed
  83bcdbb

• remove unused

  faddat

  committed
  30acea9

• make lint work in ci

  faddat

  committed
  d4d12fb

Commits on Jul 6, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  9d36046

• autofixes

  faddat

  committed
  b6aed98

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  6c9098a

Commits on Jul 8, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  12d7037

• fix foced type assertions and the "always zero" issue

  faddat

  committed
  ed76fc5

• remove fuzzstate type

  faddat

  committed
  b6922a4

• rename swapAmountsMismatchErr swapAmountsMismatchError

  faddat

  committed
  f962856

• linting v16 completed

  faddat

  committed
  2c192df

• fix randChangePercent (thanks @ValarDragon)

  faddat

  committed
  70e2cf6

• fix e2e tests

  faddat

  committed
  a313b77

• use t.Parallel correctly

  faddat

  committed
  92fe433

• add a note about parallel e2e tests, and don't call t.Parallel()

  faddat

  committed
  ca73d11

• lengthen timeout for linter

  faddat

  committed
  269bb4d

Commits on Jul 13, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  b21981e

Commits on Jul 16, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  de3762b

• lockuptypes

  faddat

  committed
  5412a54

• bump linter

  faddat

  committed
  d7fcf5b

Commits on Jul 22, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  d7474d5

Commits on Aug 3, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  82f6550

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  194768b

• tidy

  faddat

  committed
  bec5434

• sync and tidy

  faddat

  committed
  bc248ae

• check errors

  faddat

  committed
  98805e5

Commits on Aug 4, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  df564ad

• lint latest merge from main

  faddat

  committed
  e9dbf9c

Commits on Aug 6, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  7aa9f0c

• fix white space and double import

  faddat

  committed
  0b2c113

Commits on Aug 8, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  c725bd1

Commits on Aug 12, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  87beb96

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  be8c21f

• lint tests with unparam

  faddat

  committed
  1f0e28d

• remove another unused parameter

  faddat

  committed
  434575d

Commits on Aug 16, 2023

• Merge remote-tracking branch 'origin/main' into lint-all-tests

  faddat

  committed
  f2e2b8c

• go work sync

  faddat

  committed
  aa81fb6