Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ineffectual assignments #5117

Merged
merged 2 commits into from
May 8, 2023
Merged

ineffectual assignments #5117

merged 2 commits into from
May 8, 2023

Conversation

faddat
Copy link
Member

@faddat faddat commented May 7, 2023 •
edited
Loading

What is the purpose of the change

Eliminate ineffectual assignments from Osmosis tests.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@faddat faddat added no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels May 7, 2023
@faddat faddat mentioned this pull request May 8, 2023
Closed
mattverse
mattverse approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/concentrated-liquidity/incentives_test.go Outdated Show resolved Hide resolved
@mattverse mattverse merged commit 0c21214 into main May 8, 2023
@mattverse mattverse deleted the faddat/ineffasign-2 branch May 8, 2023 11:47
pysel pushed a commit that referenced this pull request Jun 6, 2023
@faddat @mattverse @pysel
ineffectual assignments (#5117)
39dfde3 
* ineffectual assignments

* Update x/concentrated-liquidity/incentives_test.go

Co-authored-by: Matt, Park <[email protected]>

---------

Co-authored-by: Matt, Park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@stackman27 stackman27 Awaiting requested review from stackman27

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder C:x/concentrated-liquidity C:x/lockup C:x/tokenfactory V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faddat @mattverse