Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate unnecessary type conversions from tests #5115

Merged
merged 4 commits into from
May 8, 2023
Merged

eliminate unnecessary type conversions from tests #5115

merged 4 commits into from
May 8, 2023

Conversation

faddat
Copy link
Member

@faddat faddat commented May 7, 2023 •
edited
Loading

What is the purpose of the change

Eliminate all unnecessary type conversions from Osmosis' tests.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/superfluid labels May 7, 2023
@faddat faddat added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks no-changelog labels May 7, 2023
@faddat faddat marked this pull request as draft May 7, 2023 23:03
@faddat faddat marked this pull request as ready for review May 7, 2023 23:40
@faddat faddat mentioned this pull request May 8, 2023
Closed
pysel
pysel approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@pysel pysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, thanks!

@p0mvn p0mvn merged commit 6e1b7a7 into main May 8, 2023
@p0mvn p0mvn deleted the faddat/unnecessary-conversions-2 branch May 8, 2023 13:02
pysel pushed a commit that referenced this pull request Jun 6, 2023
@faddat @pysel
eliminate unnecessary type conversions from tests (#5115)
36df099 
* eliminate unnecessary type conversions from tests

* fix breakage of TestQueryTotalShares

* TestQueryBalancerPoolTotalLiquidity fix

* fix TestQueryBalancerPoolTotalLiquidity -- correct call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pysel pysel pysel approved these changes

@p0mvn p0mvn p0mvn approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@stackman27 stackman27 Awaiting requested review from stackman27

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

Assignees
No one assigned
Labels
C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/superfluid V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @p0mvn @pysel