Hotfix - Fix event attribute in incentives module #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 20.47% 20.47%
=======================================
Files 163 163
Lines 23177 23177
=======================================
Hits 4745 4745
Misses 17671 17671
Partials 761 761
Continue to review full report at Codecov.
|
|
This is not how it should have been fixed. Should have used something else on the distrinfo struct. This adds too much bech32 encoding overhead to the epoch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug in the current event emitted in the incentive module.
Converting address to string without using the String() method ignores the process of going through bech32 encoding, consequently emitting events with the wrong address attribute, making it impossible to query based on the incentive events.