Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock id to return value of MsgSuperfluidUndelegateAndUnbondLockResponse #4974

Merged
merged 4 commits into from
Apr 23, 2023

Conversation

mattverse
Copy link
Member

What is the purpose of the change

MsgSuperfluidUndelegateAndUnbondLock currently does not return any value.
However, the method being called does: returns existing lock id when unlocking same amount of tokens that was in the lock, returns new lock id when a partial unlock has happened and a new lock has been created.

Missing this return value results in external integrators having to try find a different way of finding out the new lock id that have been created.

This PR fixes the problem via returning the lock id.

Brief Changelog

  • Add lock id to return value of MsgSuperfluidUndelegateAndUnbondLockResponse

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@mattverse mattverse requested a review from stackman27 as a code owner April 21, 2023 07:50
@mattverse mattverse added the V:state/breaking State machine breaking PR label Apr 21, 2023
Copy link
Contributor

@stackman27 stackman27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattverse mattverse merged commit b6b4c72 into main Apr 23, 2023
@mattverse mattverse deleted the mattverse/MsgSuperfluidUndelegateAndUnbondLock branch April 23, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/superfluid V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants