refactor: remove GetTotalShares, GetTotalLiquidity and GetExitFee from PoolI #4801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4787
What is the purpose of the change
This PR refactors
PoolI
to remove/move APIs that are either incompatible for all pools or must be defined on the pool module instead of a pool struct.Brief Changelog
poolmanager.PoolI.GetTotalPoolLiquidity
topoolmanager.PoolModuleI
gammtypes.CFMMPoolI
as wellpoolmanager.GetExitFee
togammtypes.CFMMPoolI
poolmanager.GetTotalShares
togammtypes.CFMMPoolI
GetTotalPoolLiquidity
on gamm keeperGetTotalPoolLiquidity
on CL keeperTesting and Verifying
Added tests and covered by existing
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no