-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/test(CL Fees): swap out given in fee growth tests; clean up swap tests #4127
Conversation
@@ -581,232 +560,28 @@ var ( | |||
expectErr: true, | |||
}, | |||
} | |||
) | |||
|
|||
func (s *KeeperTestSuite) TestCalcAndSwapOutAmtGivenIn() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is a problem with diff, the test is present down below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the understanding that we are adding swapInGivenOutFeeCases post fee logic PR. Nicely done, very clean (the diff was super odd but reviewing the final file instead was much easier to grok)
merging since this is a simple test refactor |
Closes: #XXX
What is the purpose of the change
Due to a merge conflict between #4021 and #4097, the fee growth validations were not added.
This PR adds the validations for the fee growth accumulator.
The changes from #4021 interfere with the assertions since they also relate to updating the fee growth accumulator. As a result, they were moved into a separate test fixture called
TestSwapOutAmtGivenIn_TickUpdates
to enable the expected fee growth validations in the original test.Lastly, it cleans up the swap test suite. See changelog for details. This clean up is necessary for #4131 and is separated here for ease of review.
Brief Changelog
TestSwapOutAmtGivenIn_TickUpdates
TestCalcAndSwapOutAmtGivenIn
swapOutGivenInFeeCases
global variableSwapTest
and reuse it where applicableTesting and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no