[CL][e2e]: CreateConcentratedPosition #4056
Conversation
pysel
added
C:e2e
V:state/compatible/no_backport
|
Wdyt about pointing this PR to |
pysel
force-pushed
the
ruslan/e2e-cl-create-position
branch
from
0976add to
59b3bf0
Compare
|
@p0mvn Current positions: |
tests/e2e/e2e_test.go
Outdated
| minTick, maxTick := cl.GetMinAndMaxTicksFromExponentAtPriceOne(sdk.NewInt(precisionFactorAtPriceOne)) | ||
|
|
||
| // Create 2 positions for node1: overlap together, overlap with 2 node3 positions) | ||
| node1.CreateConcentratedPosition(initialization.ValidatorWalletName, "[-1200]", "400", fmt.Sprintf("1000%s", denom0), fmt.Sprintf("1000%s", denom1), 0, 0, poolID) |
There was a problem hiding this comment.
What matters is using different addressed to create positions from.
We would like to have positions created from the same addresses as well as some different addresses. Overlapping and non-overlapping
There was a problem hiding this comment.
yeah, completely makes sense, fixed that. It means there is not really any use anymore for GetNodeAtIndex I created for this PR. However, it is still a pretty nice function, shall we keep it? wdyt? @p0mvn
tests/e2e/e2e_test.go
Outdated
| minTick, maxTick := cl.GetMinAndMaxTicksFromExponentAtPriceOne(sdk.NewInt(precisionFactorAtPriceOne)) | ||
|
|
||
| // Create 2 positions for node1: overlap together, overlap with 2 node3 positions) | ||
| node1.CreateConcentratedPosition(initialization.ValidatorWalletName, "[-1200]", "400", fmt.Sprintf("1000%s", denom0), fmt.Sprintf("1000%s", denom1), 0, 0, poolID) |
There was a problem hiding this comment.
It is also possible to provide ticks as ints here, but I thought it would be better to make code a little dirtier here, but keep CreateConcentratedPosition clear by avoiding transforming int-ticks to strings
tests/e2e/e2e_test.go
Outdated
| minTick, maxTick := cl.GetMinAndMaxTicksFromExponentAtPriceOne(sdk.NewInt(precisionFactorAtPriceOne)) | ||
|
|
||
| // Create 2 positions for node1: overlap together, overlap with 2 node3 positions) | ||
| node1.CreateConcentratedPosition(initialization.ValidatorWalletName, "[-1200]", "400", fmt.Sprintf("1000%s", denom0), fmt.Sprintf("1000%s", denom1), 0, 0, poolID) |
There was a problem hiding this comment.
yeah, completely makes sense, fixed that. It means there is not really any use anymore for GetNodeAtIndex I created for this PR. However, it is still a pretty nice function, shall we keep it? wdyt? @p0mvn
pysel
force-pushed
the
ruslan/e2e-cl-create-position
branch
from
7fd36f9 to
338eb63
Compare
| @@ -24,7 +24,7 @@ const ( | |||
| // It should be uploaded to Docker Hub. OSMOSIS_E2E_SKIP_UPGRADE should be unset | |||
| // for this functionality to be used. | |||
| previousVersionOsmoRepository = "osmolabs/osmosis-dev" | |||
| previousVersionOsmoTag = "v14.x-de392d2b-1674667154" | |||
| previousVersionOsmoTag = "v14.x-6b742c84-1675172347" | |||
There was a problem hiding this comment.
How were you able to push the update? Is it correctly auto-pushing to Docker hub now?
There was a problem hiding this comment.
we had #3503 this workflow to push osmosis-dev images
Closes: #4055
What is the purpose of the change
This PR adds a function -
CreateConcentratedPosition- that creates a concentrated positionBrief Changelog
CreateConcentratedPositionadded tocommands.goTesting and Verifying
Testing blocked before #4038 is merged
Documentation and Release Note
no