Remove osmomath's dependency on osmoassert & gammtypes #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
ValarDragon
added
V:state/compatible/backport
p0mvn
approved these changes
Dec 16, 2022
| // but we can't directly import that due to import cycles. | ||
| // Hence we use the same var name, in hopes that if any change there happens, | ||
| // this is caught via a CTRL+F | ||
| var MaxSpotPrice = sdk.NewDec(2).Power(128).Sub(sdk.OneDec()) |
There was a problem hiding this comment.
Would having separate constants or utils package help mitigate the import cycles?
There was a problem hiding this comment.
It would have to be in its own independent go.mod, which seems pretty annoying for now
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2022
* Remove osmomath's dependency on osmoassert & gammtypes * Add note in gamm constant * Bring pack conditional panic * One more cond panic (cherry picked from commit db97b16)
ValarDragon
added a commit
that referenced
this pull request
Dec 16, 2022
* Remove osmomath's dependency on osmoassert & gammtypes * Add note in gamm constant * Bring pack conditional panic * One more cond panic (cherry picked from commit db97b16) Co-authored-by: Dev Ojha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Needed to split osmomath into its own go.mod
This basically involved making an exported var for
gammtypes.MaxSpotPrice, and removing Conditional Panic cases. Only affects test files.