Make apply func if no err, out of gas panic, match std behavior #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
czarcas7ic
approved these changes
Jan 2, 2023
Comment on lines
+48
to
+53
| func IsOutOfGasError(err any) (bool, string) { | ||
| switch e := err.(type) { | ||
| case types.ErrorOutOfGas: | ||
| return true, e.Descriptor | ||
| case types.ErrorGasOverflow: | ||
| return true, e.Descriptor |
There was a problem hiding this comment.
What about types.ErrorNegativeGasConsumed?
There was a problem hiding this comment.
oh wow didn't know that existed, let me think about it
great catch
mattverse
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
LGTM once @czarcas7ic 's suggestion of negative error has been added!
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
ValarDragon
deleted the
dev/improve_applyfuncifnoerr_out_of_gas_logging
branch
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2487
What is the purpose of the change
So it turns out that CacheCtx and Ctx bizarrely share the same gas meter. Source: https://github.com/cosmos/cosmos-sdk/blob/main/types/context.go#L289-L303 , and that GasMeter is a pointer. (Otherwise https://github.com/cosmos/cosmos-sdk/blob/main/types/context.go#L58 ctx,GasMeter().ConsumeGas() wouldn't work)
So this PR makes it so that if in apply func if no err block fails due to out of gas, it preserves the standard out of gas behavior flow. This is not an issue for beginblock / endblock code as they should not get panics for out of gas issues. Whereas for txs, right now you get a different error code / distinct flow right now.
This ideally would be handled upstream, but alas.
This is state breaking, as it effects tx execution codes.
Brief Changelog
Testing and Verifying
This change added a test which shows:
The QA requirement for this will be to test a superfluid delegate action with and without this change, in the out of gas behavior setting. (Namely that they should both return an error, just a different error code)
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes