ProtoRev PR 1 + 2 Rebase #3681
Merged
ProtoRev PR 1 + 2 Rebase #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Configuring protorev in osmosis app + adding proto code * generating proto code + adding types implementations * implementing msg and gov types * clean up + adding a few more test cases * styling fixes * lint fixes * Updating URLs for queries and msg server to v13 * Refactor of pool statistics + errors * proto update * proto updates (snake casing for fields) * refactoring params to standard implementation * proposal handler upgrade for protorev
* setting up the keys for trading stores * trading store getters and setters * keeper testing * configuring epoch hook in app + implementing the hook + genesis state update * epoch testing * clean up docs + test suite * lint fixes * more documentation * updating token pair keys, refactoring deletion to use the same wrapper func, and moving around epoch code * creating a helper func to update the highest liquidity pools * renaming helper function
davidterpay
added
the
V:state/compatible/backport
ValarDragon
approved these changes
Dec 10, 2022
ValarDragon
added
V:state/breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR rebases the first and second PR onto the latest changes on
main. Additionally, it adds the protorev store key to the v14 upgrade. The changes for the first two PRs have already been approved and can be found here (#3587, #3646).Brief Changelog
x/protorevstore key to the v14 upgradeTesting and Verifying
This change added tests and can be verified as follows:
(example:)
x/protorevx/protorevstore key passesDocumentation and Release Note
Documentation surrounding
x/protorevcan be found here #3594.