Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reflection + Generics to delete most CLI boilerplate for queries (backport #3611) #3633

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2022

This is an automatic backport of pull request #3611 done by Mergify.
Cherry-pick of ce98bbb has failed:

On branch mergify/bp/v13.x/pr-3611
Your branch is up to date with 'origin/v13.x'.

You are currently cherry-picking commit ce98bbb7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md
	new file:   osmoutils/generic_helper.go
	new file:   osmoutils/osmocli/flag_advice.go
	new file:   osmoutils/osmocli/index_cmd.go
	new file:   osmoutils/osmocli/parsers.go
	new file:   osmoutils/osmocli/query_cmd_wrap.go
	new file:   osmoutils/osmocli/string_formatter.go
	new file:   osmoutils/osmocli/tx_cmd_wrap.go
	modified:   x/epochs/client/cli/query.go
	deleted:    x/epochs/client/cli/query_test.go
	deleted:    x/epochs/client/cli/tx.go
	modified:   x/epochs/module.go
	modified:   x/gamm/client/cli/flags.go
	modified:   x/gamm/client/cli/query.go
	modified:   x/gamm/client/cli/tx.go
	modified:   x/ibc-rate-limit/client/cli/query.go
	modified:   x/incentives/client/cli/query.go
	modified:   x/incentives/client/cli/tx.go
	modified:   x/lockup/client/cli/cli_test.go
	modified:   x/lockup/client/cli/query.go
	modified:   x/lockup/client/cli/tx.go
	modified:   x/lockup/client/testutil/test_helpers.go
	modified:   x/mint/client/cli/query.go
	deleted:    x/mint/client/cli/query_test.go
	modified:   x/pool-incentives/client/cli/cli_test.go
	modified:   x/pool-incentives/client/cli/query.go
	modified:   x/superfluid/client/cli/query.go
	modified:   x/superfluid/client/cli/tx.go
	modified:   x/tokenfactory/client/cli/query.go
	modified:   x/tokenfactory/client/cli/tx.go
	modified:   x/twap/client/cli/query.go
	modified:   x/txfees/client/cli/query.go
	modified:   x/txfees/client/cli/tx.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   x/valset-pref/client/cli/query.go
	deleted by us:   x/valset-pref/client/cli/tx.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…3611)

Makes new, far more succinct methods, to build tx and query CLI's

(cherry picked from commit ce98bbb)

# Conflicts:
#	x/valset-pref/client/cli/query.go
#	x/valset-pref/client/cli/tx.go
@ValarDragon ValarDragon merged commit fe6d544 into v13.x Dec 5, 2022
@ValarDragon ValarDragon deleted the mergify/bp/v13.x/pr-3611 branch December 5, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant