explicitly apply dragonberry patch #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
added
A:backport/v13.x
ValarDragon
approved these changes
Dec 5, 2022
|
TYSM, yikes that this was missed |
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
* explicitly apply dragonberry and clean go.mod a bit * dragonberry (cherry picked from commit da6b7d1)
ValarDragon
pushed a commit
that referenced
this pull request
Dec 5, 2022
* explicitly apply dragonberry and clean go.mod a bit * dragonberry (cherry picked from commit da6b7d1) Co-authored-by: Jacob Gadikian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The dragonberry patch may or may not be implicitly applied from Osmosis dependencies. This PR explicitly applies the dragonberry patch to osmosis in go.mod.
There is an upcoming update to ics23 v0.9.0 which will replace this, but I think this is a good idea to have in v13.0.1 (and should probably be what validators upgrade to)
The above PR may require changes to the osmosis-sdk, so for now, it likely makes sense to explicitly apply the dragonberry fix in the replace section of go.mod.
Brief Changelog
to go.mod, and make a few other small cosmetic changes to go.mod
Testing and Verifying
"Dragonberry active" should be visible in node logs.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? nox/<module>/spec/) / Osmosis docs repo / not documented)