Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/fix(stableswap): scaling factors CLI, fix bug with not saving pool to state #3332

Merged
merged 2 commits into from
Nov 10, 2022
Merged

feat/fix(stableswap): scaling factors CLI, fix bug with not saving pool to state #3332

merged 2 commits into from
Nov 10, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Nov 10, 2022 •
edited
Loading

Closes:

What is the purpose of the change

  • Fix bug with not writing pool to state after attempting to set scaling factors
  • Add CLI for setting scaling factors
  • Fix gamm pools query for stableswap

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn added the V:state/breaking State machine breaking PR label Nov 10, 2022
@github-actions github-actions bot added C:CLI C:x/gamm Changes, features and bugs related to the gamm module. labels Nov 10, 2022
@p0mvn p0mvn added A:backport/v13.x backport patches to v13.x branch V:state/compatible/backport State machine compatible PR, should be backported and removed C:CLI C:x/gamm Changes, features and bugs related to the gamm module. V:state/breaking State machine breaking PR labels Nov 10, 2022
@p0mvn p0mvn marked this pull request as ready for review November 10, 2022 22:23
@p0mvn p0mvn requested a review from a team November 10, 2022 22:23
@github-actions github-actions bot added C:CLI C:x/gamm Changes, features and bugs related to the gamm module. labels Nov 10, 2022
ValarDragon
ValarDragon approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

ValarDragon
ValarDragon reviewed Nov 10, 2022
View reviewed changes
x/gamm/keeper/pool.go
return err
}

return k.setPool(ctx, stableswapPool)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this was what was missing before, ty

@ValarDragon ValarDragon merged commit a355026 into main Nov 10, 2022
@ValarDragon ValarDragon deleted the roman/ss-scaling-factors branch November 10, 2022 22:52
mergify bot pushed a commit that referenced this pull request Nov 10, 2022
@p0mvn @mergify
feat/fix(stableswap): scaling factors CLI, fix bug with not saving po…
2964f04 
…ol to state (#3332)

* feat/fix(stableswap): scaling factors CLI, fix bug with not saving pool, fix pools query

* lint

(cherry picked from commit a355026)
@mergify mergify bot mentioned this pull request Nov 10, 2022
Merged
ValarDragon pushed a commit that referenced this pull request Nov 10, 2022
@mergify @p0mvn
feat/fix(stableswap): scaling factors CLI, fix bug with not saving po…
f912cac 
…ol to state (#3332) (#3334)

* feat/fix(stableswap): scaling factors CLI, fix bug with not saving pool, fix pools query

* lint

(cherry picked from commit a355026)

Co-authored-by: Roman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
A:backport/v13.x backport patches to v13.x branch C:CLI C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/backport State machine compatible PR, should be backported
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @ValarDragon