Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the encoding config arg to NewOsmosisApp #2587

Merged
merged 3 commits into from
Sep 3, 2022
Merged

Remove the encoding config arg to NewOsmosisApp #2587

merged 3 commits into from
Sep 3, 2022

Conversation

ValarDragon
Copy link
Member

Brief Changelog

Removes the NewEncodingConfig arg to NewOsmosisApp, which had no usecase, and was always set to app.MakeEncodingConfig() from every caller.

Testing and Verifying

This change is already covered by existing E2E tests.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@ValarDragon ValarDragon requested a review from a team September 3, 2022 16:29
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:simulator Edits simulator or simulations labels Sep 3, 2022
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Sep 3, 2022
@ValarDragon ValarDragon mentioned this pull request Sep 3, 2022
Merged
czarcas7ic
czarcas7ic approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from previous PR review!

@p0mvn p0mvn merged commit 4215475 into main Sep 3, 2022
@p0mvn p0mvn deleted the dev/reduce_app_init_arg branch September 3, 2022 18:30
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder C:docs Improvements or additions to documentation C:simulator Edits simulator or simulations
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @p0mvn @czarcas7ic