Unify cache_ctx wraps #2519
Merged
Unify cache_ctx wraps #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2022
mattverse
reviewed
Aug 29, 2022
x/epochs/types/hooks.go
Outdated
| // TODO: Thread info for which hook this is, may be dependent on larger hook system refactoring | ||
| err := osmoutils.ApplyFuncIfNoError(ctx, wrappedHookFn) | ||
| if err != nil { | ||
| ctx.Logger().Info("an epoch hook errored") |
There was a problem hiding this comment.
wdyt about logging the error itself here?
| hookFn(cacheCtx, epochIdentifier, epochNumber) | ||
| write() | ||
| ctx.EventManager().EmitEvents(cacheCtx.EventManager().Events()) | ||
| wrappedHookFn := func(ctx sdk.Context) error { |
p0mvn
approved these changes
Aug 29, 2022
mattverse
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In #2515 @puneet2019 fixed that epochs isn't returning events, due to cosmos/cosmos-sdk#12912 .
This also showed that were actually duplicating panic wrapping logic. This PR adds that fix to the general osmosis helper, and makes epochs use the general osmosis helper
Brief Changelog
Testing and Verifying
This change is already covered by existing tests, that @puneet2019 added in #2515
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no