Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: additional test cases for TestCalcJoinPoolShares (multi-coin swap) #1713

Merged
merged 10 commits into from
Jun 10, 2022
Merged

chore: additional test cases for TestCalcJoinPoolShares (multi-coin swap) #1713

merged 10 commits into from
Jun 10, 2022

Conversation

alexanderbez
Copy link
Contributor

Add two additional test cases to TestCalcJoinPoolShares where tokensIn contains multiple coins where a swap is performed.

@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jun 8, 2022
@stackman27 stackman27 mentioned this pull request Jun 9, 2022
Merged
@alexanderbez alexanderbez marked this pull request as ready for review June 9, 2022 15:18
@alexanderbez alexanderbez requested a review from a team June 9, 2022 15:18
@p0mvn p0mvn mentioned this pull request Jun 9, 2022
Merged
@alexanderbez alexanderbez added the A:backport/v10.x backport patches to v10.x branch label Jun 9, 2022
@stackman27 stackman27 mentioned this pull request Jun 9, 2022
Closed
3 tasks
@stackman27
Copy link
Contributor

Can we close this as it's replaced by #1732?

@alexanderbez
Copy link
Contributor Author

Can we close this as it's replaced by #1732?

I would prefer that it'd be based off of bez/TestCalcJoinPoolShares-swap-tests and merged into that, but I'm open to closing mine as well.

@mattverse mattverse mentioned this pull request Jun 10, 2022
Closed
@mattverse
Copy link
Member

@alexanderbez would u mind if I take over this PR real quick for test additions

@ValarDragon
Copy link
Member

go for it imo

mattverse
mattverse approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We need test cases for pools with different ratio but this is tbd in a different pr

@github-actions github-actions bot removed the C:x/gamm Changes, features and bugs related to the gamm module. label Jun 10, 2022
@mattverse mattverse force-pushed the bez/TestCalcJoinPoolShares-swap-tests branch from 88743ef to dbb8958 Compare June 10, 2022 18:45
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jun 10, 2022
@github-actions github-actions bot removed the C:x/gamm Changes, features and bugs related to the gamm module. label Jun 10, 2022
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Jun 10, 2022
@alexanderbez alexanderbez merged commit 28a6f13 into main Jun 10, 2022
@alexanderbez alexanderbez deleted the bez/TestCalcJoinPoolShares-swap-tests branch June 10, 2022 19:44
mergify bot pushed a commit that referenced this pull request Jun 10, 2022
@alexanderbez @mergify
chore: additional test cases for TestCalcJoinPoolShares (multi-coin s…
fff9276 
…wap) (#1713)

(cherry picked from commit 28a6f13)
@mergify mergify bot mentioned this pull request Jun 10, 2022
Merged
alexanderbez pushed a commit that referenced this pull request Jun 10, 2022
@mergify
chore: additional test cases for TestCalcJoinPoolShares (multi-coin s…
bd7d090 
…wap) (#1713) (#1762)
@stackman27 stackman27 mentioned this pull request Jun 10, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackman27 stackman27 stackman27 left review comments

@mattverse mattverse mattverse approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
A:backport/v10.x backport patches to v10.x branch C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @stackman27 @mattverse @ValarDragon