Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CodeQL from CI #1592

Merged
merged 2 commits into from
May 26, 2022
Merged

Remove CodeQL from CI #1592

merged 2 commits into from
May 26, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Removes CodeQL. It takes forever, and I'm unconvinced its adding anything of value. We should just get Informal's gosec fixed, and use that imo.

If folks feel like CodeQL is useful, we can investigate speedup strategies in #1578 , but atm I'm not sure its helping us any.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no, its CI
  • How is the feature or change documented? not applicable

@ValarDragon ValarDragon requested a review from a team May 26, 2022 17:17
@codecov-commenter
Copy link

Codecov Report

Merging #1592 (ef3b757) into main (4cf7a58) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   19.61%   19.61%           
=======================================
  Files         242      242           
  Lines       32267    32267           
=======================================
  Hits         6328     6328           
  Misses      24783    24783           
  Partials     1156     1156           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf7a58...ef3b757. Read the comment docs.

@mergify mergify bot merged commit d0b9251 into main May 26, 2022
@mergify mergify bot deleted the dev/remove_codeql branch May 26, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants