-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI cache #1583
Add CI cache #1583
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1583 +/- ##
=======================================
Coverage 19.53% 19.53%
=======================================
Files 242 242
Lines 32262 32262
=======================================
Hits 6303 6303
Misses 24804 24804
Partials 1155 1155 Continue to review full report at Codecov.
|
Compare the two runs
This cut out over half the time! This suggests that the go build time was around 3 minutes in every CI run, perhaps getting something similar for docker tests would help as well! We'd likely want a different cache key for the docker tests though, since we don't want it to override the go test cache. |
Last commit is trying to add a cache to test-e2e, may need a couple of go edits before we can see if it helps |
Awesome, tests are still getting rebuilt / re-run! (Evident by last commit) |
For Docker, Compare the two runs (First run, cache miss) https://github.com/osmosis-labs/osmosis/runs/6592152484?check_suite_focus=true Time went from The e2e upgrade testing time shaved 1minute 40 seconds, however docker image build increased by 30 seconds. So we still need to separately figure out how to speedup docker image building (perhaps incremental build) and further speeding up the e2e tests. |
Linter speed difference: (Run with no cache) https://github.com/osmosis-labs/osmosis/runs/6591900239?check_suite_focus=true Time difference is |
What is the purpose of the change
Try adding a cache for go build data, to help speedup CI. Copied from mvdan here: https://github.com/mvdan/github-actions-golang/blob/master/.github/workflows/test.yml
cref #1578
Brief Changelog
Testing and Verifying
We will need to keep an eye on if there are edge cases that make this not work / give incorrect results, or things don't speedup. A bit hard to know this without it being in place though.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no (I don't think CI is in scope)