-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tokenfactory create denom fee #1435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1435 +/- ##
==========================================
- Coverage 19.82% 19.32% -0.50%
==========================================
Files 202 229 +27
Lines 27685 31405 +3720
==========================================
+ Hits 5489 6070 +581
- Misses 21175 24224 +3049
- Partials 1021 1111 +90
Continue to review full report at Codecov.
|
This was referenced May 6, 2022
Merged
ValarDragon
reviewed
May 6, 2022
ValarDragon
approved these changes
May 6, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1438
What is the purpose of the change
Adds a base fee for creating denoms with x/tokenfactory for spam resistance
Brief change log
Adds a params struct to x/tokenfactory and uses that to store denoms
Testing and Verifying
This change added a check to make sure fees were being paid in tests
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)