Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format balancer amm_test.go #1355

Merged
merged 2 commits into from
Apr 26, 2022
Merged

chore: format balancer amm_test.go #1355

merged 2 commits into from
Apr 26, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Apr 26, 2022

Closes: #XXX

What is the purpose of the change

amm_test.go is not formatted correctly (was not caught by Automerge in #1344 ). This PR fixes the formatting error

Brief change log

  • formatted the problematic file

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Apr 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #1355 (63ecec2) into main (f56fbe5) will decrease coverage by 0.04%.
The diff coverage is 4.00%.

@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   19.82%   19.77%   -0.05%     
==========================================
  Files         202      202              
  Lines       27685    27718      +33     
==========================================
- Hits         5489     5482       -7     
- Misses      21175    21215      +40     
  Partials     1021     1021              
Impacted Files Coverage Δ
x/gamm/pool-models/balancer/amm.go 17.58% <ø> (ø)
x/gamm/pool-models/stableswap/amm.go 43.28% <0.00%> (-12.49%) ⬇️
x/gamm/pool-models/stableswap/pool.go 0.00% <0.00%> (ø)
x/gamm/client/cli/tx.go 59.50% <100.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd1ce7...63ecec2. Read the comment docs.

Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p0mvn p0mvn merged commit a56fe51 into main Apr 26, 2022
@p0mvn p0mvn deleted the roman/fmt branch April 26, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants