Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade handler for v8 #1304

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

This PR adds boilerplate for the v8 upgrade handler. Simplifies the logic for upgrade store handler updates. Intended as a precursor for #1301

Brief change log

  • Adds boilerplate for the v8 upgrade handler. I don't think this necessitates an entry in the actual changelog.

Testing and Verifying

This change should be tested in upcoming upgrade handler testing on testnets / in framework. It needs an end to end test to properly test changes to the store loaders.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? NA

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #1304 (535240d) into main (0cfa729) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   20.26%   20.26%           
=======================================
  Files         203      203           
  Lines       26824    26824           
=======================================
  Hits         5437     5437           
  Misses      20377    20377           
  Partials     1010     1010           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cfa729...535240d. Read the comment docs.

@ValarDragon ValarDragon mentioned this pull request Apr 20, 2022
@ValarDragon ValarDragon merged commit 68f2661 into main Apr 22, 2022
@ValarDragon ValarDragon deleted the dev/v8-upgrade-handler-boilerplate branch April 22, 2022 03:38
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was wondering if there's any logic we need to handle within the upgrade handler for v8.

Should we also create an issue to change main to v8?

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants