Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram for superfluid staking #1295

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Conversation

daniel-farina
Copy link
Contributor

@daniel-farina daniel-farina commented Apr 19, 2022

  • Moving the diagram to this repo from the docs repo.
  • Update link to be absolute to this repo in order to use it on the docs site

Moving the diagram to this repo from the docs repo. 
WIP
@daniel-farina daniel-farina requested a review from xBalbinus April 19, 2022 14:42
@daniel-farina
Copy link
Contributor Author

This is ready, just moving an image from the docs repo to this repo.

@daniel-farina daniel-farina marked this pull request as ready for review April 19, 2022 14:52
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #1295 (3966db0) into main (b6d342a) will decrease coverage by 0.75%.
The diff coverage is 9.32%.

@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   20.90%   20.14%   -0.76%     
==========================================
  Files         196      203       +7     
  Lines       25425    26824    +1399     
==========================================
+ Hits         5316     5405      +89     
- Misses      19118    20412    +1294     
- Partials      991     1007      +16     
Impacted Files Coverage Δ
x/claim/abci.go 0.00% <ø> (ø)
x/claim/client/cli/query.go 34.45% <ø> (ø)
x/claim/client/cli/tx.go 0.00% <ø> (ø)
x/claim/handler.go 0.00% <ø> (ø)
x/claim/keeper/claim.go 64.33% <ø> (ø)
x/claim/keeper/grpc_query.go 2.50% <ø> (ø)
x/claim/keeper/hooks.go 28.00% <ø> (ø)
x/claim/keeper/keeper.go 87.50% <ø> (ø)
x/claim/keeper/params.go 81.81% <ø> (ø)
x/claim/module.go 58.06% <ø> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8fa5f2...3966db0. Read the comment docs.

Copy link
Contributor

@xBalbinus xBalbinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xBalbinus xBalbinus merged commit ee2fa7c into main Apr 19, 2022
@xBalbinus xBalbinus deleted the daniel-farina/superfluid-docs branch April 19, 2022 17:43
@faddat faddat mentioned this pull request Apr 19, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants