Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluid staking PR #1283

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Superfluid staking PR #1283

merged 2 commits into from
Apr 18, 2022

Conversation

xBalbinus
Copy link
Contributor

@xBalbinus xBalbinus commented Apr 18, 2022

Closes: #1073

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #1283 (0b9d493) into main (7d45d8e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1283   +/-   ##
=======================================
  Coverage   20.08%   20.08%           
=======================================
  Files         203      203           
  Lines       26786    26786           
=======================================
  Hits         5379     5379           
  Misses      20409    20409           
  Partials      998      998           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d45d8e...0b9d493. Read the comment docs.

@xBalbinus
Copy link
Contributor Author

This PR does:

  • Merges all MD files into one ginormous README for easy reading
  • A brief added introduction docs to the superfluid state machine itself.

@daniel-farina
Copy link
Contributor

lgtm. This closes #1073. Update PR with link to it.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial section is much better! I'm also a big fan of everything in a single file, I never liked the spec folder breakdown

@ValarDragon ValarDragon merged commit 4e12c8e into main Apr 18, 2022
@ValarDragon ValarDragon deleted the xiangan/superfluid branch April 18, 2022 21:24
@faddat faddat mentioned this pull request Apr 19, 2022
4 tasks
@inFocus7 inFocus7 mentioned this pull request Jul 3, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document Superfluid state machine itself
4 participants