-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade zondax/hid to remove build message warning on macos 12 #1268
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
- Coverage 20.90% 20.08% -0.83%
==========================================
Files 196 203 +7
Lines 25425 26786 +1361
==========================================
+ Hits 5316 5379 +63
- Misses 19118 20409 +1291
- Partials 991 998 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delightful!
Co-authored-by: jlbit <[email protected]> (cherry picked from commit f2dfd97)
#1274) Co-authored-by: jlbit <[email protected]> (cherry picked from commit f2dfd97) Co-authored-by: jlbit <[email protected]>
Closes: #1267
NOTE! I‘m using the proposed PR template for this PR, to demonstrate how it can work
What is the purpose of the change
Upgrade zondax/hid to remove build warnings and noise on mac
Brief change log
Please reference the before v.s. after screenshots to see the warnings are gone and build messages are much cleaner. Note that the screenshot diffs are already based on #1266 which removed massive keyring warnings already
Screenshot before this change:
Screenshot after upgrading the lib:
PR Formatting
Testing and Verifying
I tested locally,
make test
passed.This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (no)