Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade zondax/hid to remove build message warning on macos 12 #1268

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

jlbit
Copy link
Contributor

@jlbit jlbit commented Apr 16, 2022

Closes: #1267

NOTE! I‘m using the proposed PR template for this PR, to demonstrate how it can work

What is the purpose of the change

Upgrade zondax/hid to remove build warnings and noise on mac

Brief change log

  • upgrade zondax/hid from 0.9.0 to 0.9.1, by referencing this fix from Cosmos SDK

Please reference the before v.s. after screenshots to see the warnings are gone and build messages are much cleaner. Note that the screenshot diffs are already based on #1266 which removed massive keyring warnings already

Screenshot before this change:

image

Screenshot after upgrading the lib:

image

PR Formatting

Testing and Verifying

I tested locally, make test passed.

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
  • How is the feature or change documented? (not applicable)

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #1268 (24acadd) into main (b6d342a) will decrease coverage by 0.82%.
The diff coverage is 9.38%.

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   20.90%   20.08%   -0.83%     
==========================================
  Files         196      203       +7     
  Lines       25425    26786    +1361     
==========================================
+ Hits         5316     5379      +63     
- Misses      19118    20409    +1291     
- Partials      991      998       +7     
Impacted Files Coverage Δ
x/claim/abci.go 0.00% <ø> (ø)
x/claim/client/cli/query.go 34.45% <ø> (ø)
x/claim/client/cli/tx.go 0.00% <ø> (ø)
x/claim/handler.go 0.00% <ø> (ø)
x/claim/keeper/claim.go 64.33% <ø> (ø)
x/claim/keeper/grpc_query.go 2.50% <ø> (ø)
x/claim/keeper/hooks.go 28.00% <ø> (ø)
x/claim/keeper/keeper.go 87.50% <ø> (ø)
x/claim/keeper/params.go 81.81% <ø> (ø)
x/claim/module.go 58.06% <ø> (ø)
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1530e4a...24acadd. Read the comment docs.

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delightful!

@faddat faddat merged commit f2dfd97 into osmosis-labs:main Apr 18, 2022
@mattverse mattverse added the A:backport/v7.x Do not use. backport patches to v7.x branch label Apr 18, 2022
mergify bot pushed a commit that referenced this pull request Apr 18, 2022
ValarDragon pushed a commit that referenced this pull request Apr 18, 2022
#1274)

Co-authored-by: jlbit <[email protected]>
(cherry picked from commit f2dfd97)

Co-authored-by: jlbit <[email protected]>
@faddat faddat mentioned this pull request Apr 19, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

upgrade zondax/hid to remove build warnings on MacOS 12
5 participants