x/lockup: Get updated lock for events

[giansalex]

Current endtime in logs (MsgBeginUnlocking) is wrong: 0001-01-01 00:00:00 +0000 UTC because it is updated inside BeginUnlock and eventManager uses outdated lock, i wanted to return the updated lock from that function but it has many references, a quick fix is to get the lock again.

this also includes verifying the owner conditional before BeginUnlock is executed.

endtime field could also be added to MsgBeginUnlockingResponse.

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

[codecov-commenter]

Codecov Report

Merging #1184 (e02a323) into main (cc0ec41) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##             main    #1184   +/-   ##
=======================================
  Coverage   21.06%   21.06%           
=======================================
  Files         196      196           
  Lines       25302    25305    +3     
=======================================
+ Hits         5330     5331    +1     
- Misses      19011    19012    +1     
- Partials      961      962    +1     

Impacted Files	Coverage Δ
x/lockup/keeper/msg_server.go	82.50% <20.00%> (-1.92%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0ec41...e02a323. Read the comment docs.

[alexanderbez]

We should add a changelog entry for this too please 🙏

[mattverse]

Thanks for this PR + the extra check for unlocking! LGTM!

[ValarDragon]

LGTM! I wonder if its worth reconsidering at some point how we do events. It does feel a bit silly that we have to do a second GetLockById in the main method. Maybe we should move towards k.createUnlockEvent(ctx, lockId) ? Or move events into the keeper methods rather than msg server?