Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AfterEpochEnd called with wrong epoch number #1043

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

czarcas7ic
Copy link
Member

This PR calls EpochEnd prior to increasing the CurrentEpoch by 1 as discussed here

Once approved, I will advise all integrators to test their systems off main before we push this to the next 7.x release (before we do this, I think we need to base main off 7.0.2, its still on 7.0.0 I believe)


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@czarcas7ic czarcas7ic requested a review from ValarDragon March 4, 2022 03:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #1043 (84da8ea) into main (a5589e0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   20.60%   20.60%           
=======================================
  Files         193      193           
  Lines       25237    25237           
=======================================
  Hits         5199     5199           
  Misses      19084    19084           
  Partials      954      954           
Impacted Files Coverage Δ
x/epochs/abci.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5589e0...84da8ea. Read the comment docs.

@mattverse mattverse self-requested a review March 7, 2022 05:37
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does simply calling AfterEpochEnd with the incremented epoch number fix the bug?
Just curious, AfterEpochEnd(https://github.com/osmosis-labs/osmosis/blob/main/x/incentives/keeper/hooks.go#L13-L45) doesn't seem like it's doing anything with the epochNumber, or I might simply be missing some part

@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 7, 2022
@ValarDragon ValarDragon mentioned this pull request Mar 9, 2022
4 tasks
@czarcas7ic czarcas7ic merged commit fb9cb2e into main Mar 17, 2022
@czarcas7ic czarcas7ic deleted the adam/epochs-patch branch March 17, 2022 15:42
mergify bot pushed a commit that referenced this pull request Mar 17, 2022
ValarDragon pushed a commit that referenced this pull request Mar 28, 2022
(cherry picked from commit fb9cb2e)

Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants