Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci/code-gen): upgrade handler code gen bumps up e2e-init version #3632

Closed
p0mvn opened this issue Dec 5, 2022 · 1 comment · Fixed by #4031
Closed

feat(ci/code-gen): upgrade handler code gen bumps up e2e-init version #3632

p0mvn opened this issue Dec 5, 2022 · 1 comment · Fixed by #4031
Assignees

Comments

@p0mvn
Copy link
Member

p0mvn commented Dec 5, 2022

Background

This is a follow-up to: #3628

Suggested Design

The upgrade-handler CI job should also bump up the previous e2e init version:

previousVersionInitTag = "v12.2.0"

Assume we are upgrading a v14 upgrade handler.

The logic should work as follows:

  1. Query the latest tag from the docker hub: https://hub.docker.com/r/osmolabs/osmosis-e2e-init-chain/tags

  • If the major version latest tag matches 14 - 1 = 13, choose that full version. It can be v13.0.0 or v13.1.0 or v13.0.1
  • if the major version latest tag does not match 13 (e.g. v12.2.0). Change it to v13.0.0 (14 - 1 = 13)

Similarly, it should also bump up previousVersionOsmoTag

Acceptance Criteria

  • upgrade handler code-gen script is updated to choose the appropriate versions for previousVersionOsmoTag
  • upgrade handler code-gen script is updated to choose the appropriate versions for previousVersionInitTag
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Dec 5, 2022
@p0mvn p0mvn changed the title fix(ci/code-gen): upgrade handler code gen bumps up e2e-init version feat(ci/code-gen): upgrade handler code gen bumps up e2e-init version Dec 5, 2022
MasterPi-2124 added a commit to MasterPi-2124/osmosis that referenced this issue Dec 21, 2022
@MasterPi-2124
Copy link
Contributor

MasterPi-2124 commented Dec 21, 2022

I saw that you changed previousVersionOsmoRepository to osmolabs/osmosis-dev, and the tags in there are really hard to be identified as suitable for changing. So I filter them to only check on tags in these example formats:

  • 13.1.2 (no any alphabets ending)
  • 13.2
    If there are not any tags available, the default tag should be 13.0.0

previousVersionInitTag is the same as above with the letter v as prefix. Detail can be seen at: https://github.com/MasterPi-2124/osmosis/pull/12/files#diff-37654f3536c020a472bfd696ce2e8f7f7fb0c1e5e8cd58b3d69e68d562d1cda0

p0mvn pushed a commit that referenced this issue Jan 18, 2023
* #3628

* #3632

* macos sed syntax

* fix ci token

* debug

* add token

* update E2E_UPGRADE_VERSION version on Makefile as well

* Remove dupplication

* Update empty_upgrade_handler_gen.sh

* Fix proto

* remove route test

* revert branch

Co-authored-by: Master Pi <[email protected]>
p0mvn pushed a commit that referenced this issue Jan 18, 2023
* #3628

* #3632

* macos sed syntax

* fix ci token

* debug

* add token

* update E2E_UPGRADE_VERSION version on Makefile as well

* Update empty_upgrade_handler_gen.sh
@github-project-automation github-project-automation bot moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants